search

olliw42 / mLRS-docu

Documentation for the mLRS project
GNU General Public License v3.0
35 stars 11 forks source link

E5 Single LED #130

Closed jlpoltrack closed 7 months ago

jlpoltrack commented 7 months ago

To address https://github.com/olliw42/mLRS-docu/issues/129

olliw42 commented 7 months ago

many thx. it's abit confusing. I guess it could be made abit more obvious that one really doesn't have to do the LED thing (in fact neither LED+R nor the diode thing), i.e., it's really just the soldering of wires. The intro might be a bit less "scary". Maybe one could move the note for the green led down to below the note for the diode, and in the list just have a green led: none (see also note below). Juts random thoughts.

jlpoltrack commented 7 months ago

Kept the LED + Schottky diode in the images at the moment and reworked the text. If you're thinking we can remove the LED + Schottky diode from the images - let me know.

olliw42 commented 7 months ago

lgtm

I guess on could draw the lines connecting the diode, led, and R in dashed to emphasize their optionality, but that's nitpick. Should do fine as is. :)

THX!

jlpoltrack commented 7 months ago

I guess on could draw the lines connecting the diode, led, and R in dashed to emphasize their optionality, but that's nitpick. Should do fine as is. :)

Good idea - new photos added. Please take quick look and I will merge.

olliw42 commented 7 months ago

F A N T A S T I C

lgtm