search

olliw42 / mLRS-docu

Documentation for the mLRS project
GNU General Public License v3.0
30 stars 10 forks source link

r9 upload improvements #136

Closed jlpoltrack closed 5 months ago

jlpoltrack commented 5 months ago

Title, to incorporate suggestions from @4O6FPV

olliw42 commented 5 months ago

THX!

lgtm

suggestion to keep attribution. Either fist merge the previous PR and then yours as follow up PR, or add as coauther (add a line Co-authored-by: name <name@example.com> into the final commit message, https://docs.github.com/de/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#commits-mit-co-autor-auf-github)

jlpoltrack commented 5 months ago

@4O6FPV If you want, happy to give you credit on this PR but would need your Github no reply email. You can find it under Account > Settings > Emails, looks like 'ID+USERNAME@users.noreply.github.com'

olliw42 commented 5 months ago

Co-authored-by: @4O6FPV

this should do it IMHO

jlpoltrack commented 5 months ago

this should do it IMHO

Okay, added a commit with co-author credit.

olliw42 commented 5 months ago

lgtm

4O6FPV commented 5 months ago

@4O6FPV If you want, happy to give you credit on this PR but would need your Github no reply email. You can find it under Account > Settings > Emails, looks like 'ID+USERNAME@users.noreply.github.com'

@jlpoltrack No need just hope it clears up some confusion. Sorry for wasting your guys time earlier. I am not well versed in github but trying to learn more.