search

olliw42 / mLRS-docu

Documentation for the mLRS project
GNU General Public License v3.0
30 stars 10 forks source link

mavlink parameters, first attempt #180

Closed olliw42 closed 1 month ago

olliw42 commented 2 months ago

first attempt at describing the mavlink parameter support of mLRS

jlpoltrack commented 1 month ago

Put down a few thoughts / suggestions - one more outstanding item - any thoughts on how / where to link from the main Readme?

olliw42 commented 1 month ago

MANY THX

could you actually edit it directly? or isn't this possible?

jlpoltrack commented 1 month ago

could you actually edit it directly? or isn't this possible?

Okay, I went through and incorporated my suggestions - take a look and share any feedback.

olliw42 commented 1 month ago

very cool !! many thx.

olliw42 commented 1 month ago

as regards of how to link to I have no opinion. Maybe from Advanced Options. I'm also not sure it needs to be linked to quickly. All I wanted for now is to have a page to refere to. I guess the whole thing will need more testing by other users.

jlpoltrack commented 1 month ago

Made a few small tweaks and added a link from the Readme - will merge later today.

olliw42 commented 1 month ago

great. many thx. did you give it a try and test yourself?

should need also adaption to the config settings doc page (new parameter)

I wonder if one shouldn't wait with merging until the next release (I think then we have tested matek properly, we should do a next release, so matek has a defined firmware to ship with)

jlpoltrack commented 1 month ago

did you give it a try and test yourself?

Yes, I will say - it's rather interesting seeing MP connect to something that isn't a FC.

image

should need also adaption to the config settings doc page (new parameter)

Will add a new commit for this shortly.

I wonder if one shouldn't wait with merging until the next release (I think then we have tested matek properly, we should do a next release, so matek has a defined firmware to ship with)

Okay - will just leave it until later decision.

olliw42 commented 1 month ago

I will say - it's rather interesting seeing MP connect to something that isn't a FC.

that's my normal live ... on my copter I do have (since years) a full fledged MAVLink gimbal and full fledged MAVLink converted gopro camera .... :)

jlpoltrack commented 1 month ago

@olliw42 With 1.3 release are you comfortable now with merging?

olliw42 commented 1 month ago

thx for recalling! yes :)