search

olliw42 / mLRS-docu

Documentation for the mLRS project
GNU General Public License v3.0
30 stars 10 forks source link

msp: take b14ckyy's stuff, improve a little bit, link into main #189

Closed olliw42 closed 2 weeks ago

olliw42 commented 2 weeks ago

title says it based on https://github.com/olliw42/mLRS-docu/pull/187 just to make something visible to users

can be for sure changed anytime later as you guys prefer :)

@b14ckyy (somehow couldn't add you as reviewer)

jlpoltrack commented 2 weeks ago

I'm fine to merge. @b14ckyy could you take a quick look? Once this gets merged it would make sense to close your PR and then start a fresh one.

olliw42 commented 2 weeks ago

let's maybe set a timeout timer for a response :) I looked into the fb group the other day and got a feeling we should have just some doc

jlpoltrack commented 2 weeks ago

let's maybe set a timeout timer for a response :)

Alright, I'll plan to merge 24 hours from now.

b14ckyy commented 2 weeks ago

Hi guys. I am really sorry for my sparse replies. Bit of shit going on. Yes that looks good to me. previously I wanted to separate the mspX and INAV part but actually its not worth it for the 5 lines that the mspX description need.

Edit: Just wondering if we should cover the MavlinkX part with INAV at all. The fact it works is more a side effect of the ELRS related changes in INAV. But MSP should be used anyway. I think for a Mavlink-RC setup for special cases like Crossbow trackers we can have a guide in the INAV repo, not here.

jlpoltrack commented 2 weeks ago

Just wondering if we should cover the MavlinkX part with INAV at all. The fact it works is more a side effect of the ELRS related changes in INAV. But MSP should be used anyway. I think for a Mavlink-RC setup for special cases like Crossbow trackers we can have a guide in the INAV repo, not here.

Thanks for the response. Your call on quoted topic - can always be added on at a future date as well.

olliw42 commented 2 weeks ago

THX :)