search

olliw42 / mLRS-docu

Documentation for the mLRS project
GNU General Public License v3.0
35 stars 11 forks source link

Add steps for flashing via Ardupilot passthrough #195

Closed brad112358 closed 1 month ago

brad112358 commented 1 month ago

This should be especially useful for FC with built-in serial ELRS receivers

jlpoltrack commented 1 month ago

Looks good - one comment.

olliw42 commented 1 month ago

great addition. many thx!

Just a minor comment: I find it a bit confusing because it only "late" becomes clear we are talking about ArduPilot (note, we have INAV too). Maybe one also would want to swap and start with the probablöy more common situation. So, maybe

"If you have already connected your receiver to your ArduPilot flight controller or your ELRS receiver is built-in to your flight controller, ..."

I guess I also would wrote "flight controller" instead of "Flight Controller" or "FC" ...

jlpoltrack commented 1 month ago

Thanks Brad - this looks good to me. Olli, please chime in if you have any more feedback otherwise will merge some time tomorrow.

olliw42 commented 1 month ago

excellent!

brad112358 commented 1 month ago

I was just about to comment to wait a bit. I've been doing more testing to confirm some behavior before I do a PR for the ArduPilot docs and I found a problem with leaving the protocol set to mavlink. I'll do a second PR here to fix it soon.