search

olliw42 / mLRS

2.4 GHz & 915/868 MHz & 433 MHz/70 cm LoRa based telemetry and radio link for remote controlled vehicles
GNU General Public License v3.0
344 stars 78 forks source link

Some code problem #1

Closed Lance0724 closed 2 years ago

Lance0724 commented 2 years ago
  1. There are so many hard code local path(like "C:/Users/Olli/Documents/GitHub/.....") in the project file ( ".XXXXX" file like .project/.cproject)
  2. Implement the method of the class in the header file (like rxstats.h)
  3. Define global variables in header files( in common.h , the section: "Common Variables " )
Lance0724 commented 2 years ago

I`m The First ~ 😄

olliw42 commented 2 years ago

many thx

yeah, I'm not really happy with STM32CubeIDE ... and I use it only for short ... I noted these hard coded paths too, but I frankly have no idea how to overcome that

any help of how to get STM32CubeIde to behave well such that it can be transferred would be massively appreciated

olliw42 commented 2 years ago

@Lance0724 solved 1. by improving the setup procedure. Points 2. & 3. are really not code problems but rather taste. So I close the issue. Please do not hesitate to reopen if you feel it needs further consideration.

Lance0724 commented 2 years ago
262db194fd812c4f1ca5f33867d811c

Build Finished. 😄 New scenario is valid

olliw42 commented 2 years ago

great! many thx for the feedback