search

olliw42 / mLRS

2.4 GHz & 915/868 MHz & 433 MHz/70 cm LoRa based telemetry and radio link for remote controlled vehicles
GNU General Public License v3.0
279 stars 58 forks source link

high refresh crsf tweak #122

Closed jlpoltrack closed 10 months ago

jlpoltrack commented 10 months ago

Have been doing some testing with 100, 111 and 125 Hz modes for FLRC and this change was needed for all of them.

olliw42 commented 10 months ago

@jlpoltrack wouldn't 10ms/100Hz be ok with just slowing down by a factor 2 (i.e. with cnt >1)? I wonder if it would be worth to add two cases, one for rate_ms < 20 ms which slows by factor of 2, and one with < 10ms which slows by a factor of 3, like now. Or isn't it just not worth the effort, as it's not really noticable? Any insights/thoughts?

jlpoltrack commented 10 months ago

I don't notice any difference on the radio and since it is wanted to only have 1 FLRC mode, I think just having one condition makes more sense.

olliw42 commented 10 months ago

thx couldn't it make sense to set the limit more conversatively, I mean, the next is at 20 ms, and we probably want to start slowing down sonner than at 10 ms (at let's say 15 ms there already wouldn't be space for telemrtry frames). So maybe we should change to rate_ms <= 19 or so ...

jlpoltrack commented 10 months ago

thx couldn't it make sense to set the limit more conversatively, I mean, the next is at 20 ms, and we probably want to start slowing down sonner than at 10 ms (at let's say 15 ms there already wouldn't be space for telemrtry frames). So maybe we should change to rate_ms <= 19 or so ...

Yea, this makes sense to me. Will update

olliw42 commented 10 months ago

MANY THX!!