Closed tmcadam closed 2 months ago
why does this want to go into main? is dev-esp-rx-td finsihed and sorted out already?
why does this want to go into main? is dev-esp-rx-td finsihed and sorted out already?
Far from it, I opened the draft PR as a place to coordinate and discuss the outstanding development and testing needed.
sorry, I'm still a bit puzzled about what we want to do here in my naive view, in order to advance dev-esp-rx-td branch, we PR to the dev-esp-rx-td branch. Only once the dev-esp-rx-td branch is in a state to be merged to main, or has added commits which shall be brought over to main, one would PR it to bring to main. The discussion around dev-esp-rx-td branch ergo wouldn't be in such a PR since ... kind of by definition dev-esp-rx-td branch was considered ok for merge. like so, isn't it a duplication?
I would think we want things in dev-esp-rx-td for as long as it is under dev and/or testing. Not sure what your idea is.
sorry, I'm still a bit puzzled about what we want to do here in my naive view, in order to advance dev-esp-rx-td branch, we PR to the dev-esp-rx-td branch. Only once the dev-esp-rx-td branch is in a state to be merged to main, or has added commits which shall be brought over to main, one would PR it to bring to main. The discussion around dev-esp-rx-td branch ergo wouldn't be in such a PR since ... kind of by definition dev-esp-rx-td branch was considered ok for merge. like so, isn't it a duplication?
I would think we want things in dev-esp-rx-td for as long as it is under dev and/or testing. Not sure what your idea is.
Yes, you understand correctly. All development will take place in dev-esp-rx-td
. We all contribute changes to the branch dev-esp-rx-td
through PRs from our own branches.
It's not a duplication, it's another layer of PR. This PR is just automatically tracking the changes dev-esp-rx-td
i.e. everyone's contributions in one place. They can be reviewed together here, this PR is tracking the readiness of the dev-esp-rx-td
to merge to main
.
When dev-esp-rx-td
is "ready", maybe some days or weeks away. We can approve and merge here.
I'm sorry, but I still don't get it. To me it still looks like an unneeded and confusing duplication with no benefit. But I will let you guys do your thing and observe what this is going to be, I maybe then understand :)
I'm sorry, but I still don't get it. To me it still looks like an unneeded and confusing duplication with no benefit. But I will let you guys do your thing and observe what this is going to be, I maybe then understand :)
Thanks, lets try it and see, if it isn't helping matters we use another approach. Apologies for my poor explanation!
FLRC stress test (2x recommended stream rates):
Tested on bench with latest commit on Matek ELRS-D and BetaFPV Super - looks good.
Bench tested with R9M and Generic 900 RX. no issues seen. This is looking really good now. Amazing effort @jlpoltrack and @olliw42
100(100),100, -037,-024, 004; 00000, 00653;
100(100),100, -036,-025, 003; 00000, 00653;
100(100),100, -037,-024, 004; 00000, 00693;
100(100),100, -063,-054, 004; 00000, 00693;
100(100),100, -036,-025, 004; 00000, 00986;
100(100),100, -037,-024, 003; 00000, 00986;
100(100),100, -037,-025, 003; 00000, 00653;
100(100),100, -036,-024, 004; 00000, 00653;
100(100),100, -067,-051, 003; 00000, 00653;
100(100),100, -036,-023, 004; 00000, 00653;
100(100),100, -036,-023, 003; 00000, 00655;
100(100),100, -034,-022, 004; 00000, 00653;
100(100),100, -036,-024, 003; 00000, 00653;
100(100),100, -053,-042, 003; 00000, 00653;
100(100),100, -035,-023, 003; 00000, 00653;
100(100),100, -035,-023, 004; 00000, 00653;
100(100),100, -036,-024, 004; 00000, 00653;
100(100),100, -035,-023, 002; 00000, 00679;
100(100),100, -052,-040, 003; 00000, 00679;
100(100),100, -036,-023, 004; 00000, 00653;
100(100),100, -036,-023, 003; 00000, 00653;
100(100),100, -035,-023, 004; 00000, 00653;
100(100),100, -036,-023, 003; 00000, 00653;
100(100),100, -052,-040, 003; 00000, 00653;
100(100),100, -035,-023, 003; 00000, 00653;
100(100),100, -036,-023, 003; 00000, 00693;
I haven't done anything essential here ;) THX for your testing I will retest with my RP4TD this evening, and then merge ...
tested on bench for
will wait few hours, and if no complains will merge :):):)
Co-authored-by: jlpoltrack 41841496+jlpoltrack@users.noreply.github.com
WORK IN PROGRESS : DO NOT MERGE
This PR is to add support for ESP32 based True Diversity ELRS receivers.