olliw42 / mLRS

2.4 GHz & 915/868 MHz & 433 MHz/70 cm LoRa based telemetry and radio link for remote controlled vehicles
GNU General Public License v3.0
266 stars 55 forks source link

rx, tx SX127x, rfo define #160

Closed jlpoltrack closed 2 months ago

jlpoltrack commented 2 months ago

New define 'SX_USE_RFO' for SX127x hardware that uses the RFO pin instead of the PA_BOOST pin for output. Tested by Joost on BR3.

olliw42 commented 2 months ago

looks good not sure it would be a bit nicer to call it SX_USE_PA_RFO, leave it to your decission if you want to change

I know, it's not much better in other places, specifically SX_USE_DCDC is also a bit short. I guess I will change it to SX_USE_REGULATOR_MODE_DCDC.

jlpoltrack commented 2 months ago

I prefer the shorter name since that's how the datasheet refers to these pins:

image

No rush to merge.