search

olliw42 / mLRS

2.4 GHz & 915/868 MHz & 433 MHz/70 cm LoRa based telemetry and radio link for remote controlled vehicles
GNU General Public License v3.0
266 stars 55 forks source link

esp, separate out device_config.h, hal.h, streamline diy boards #171

Closed olliw42 closed 2 months ago

olliw42 commented 2 months ago

@tmcadam @jlpoltrack

the number of esp targets seem to grow, and I alos have an impression that we are rather moving towards supporting any kind of elrs device, even devices which may not be the most reasonable choice such e.g. the BR1 or BR3, I suggest to separate outthe esp target definitions into their own files ...

in some future we potentially may consider making them even more canonical or even auto generated, as the esp hal files seem to be very redundant

the pr also renames the diy/dev boards to a canoncial naming scheme. A canonical naming schem can be helpful, e.g. in the run py script for the stm32 targets this allows a more fine grained selection of what to do.

This PR should come before https://github.com/olliw42/mLRS/pull/170, and https://github.com/olliw42/mLRS/pull/170 would have to be rebased accordingly.

tmcadam commented 2 months ago

I like this. These files were getting a bit big to work with.

Also like renaming the diy boards to dev boards, which is more accurate.

olliw42 commented 2 months ago

I suppose @jlpoltrack has seen it by now and ddin't disagree with you. So, based on approval by one esp dev I merge. :)

THX !!