esp, esp lib improvements, comments&tidy

olliw42 / mLRS

2.4 GHz & 915/868 MHz & 433 MHz/70 cm LoRa based telemetry and radio link for remote controlled vehicles

GNU General Public License v3.0

310 stars 72 forks source link

esp, esp lib improvements, comments&tidy #177

Closed olliw42 closed 5 months ago

olliw42 commented 5 months ago

some few additions/changes to the esp lib files, and a comment this brings over some stuff from the owpr-esp-tx branch

less IRAM static inline
gpio handling for pin >= 32
some comments nfc

should be a light review :)

jlpoltrack commented 5 months ago

Will test more later, but just a quick IRAM check - no change:

SuperD, current main:

SuperD, this branch:

I believe the reason for this is because the configs in platformio.ini are taking precedence.

olliw42 commented 5 months ago

very cool, thx! just did another small commit to change y to 1 in the platformio.ini ... should have been changed to 1 already, not sure where this was scrambled up...

jlpoltrack commented 5 months ago

Tested on SuperD, looks good.

tmcadam commented 5 months ago

Looks fine to me. I can test on hardware tonight if you would like another hardware test? If not I am happy to approve as is.

olliw42 commented 5 months ago

you guys could merge?

jlpoltrack commented 5 months ago

Seems like everyone is good - will merge.