search

olliw42 / mLRS

2.4 GHz & 915/868 MHz & 433 MHz/70 cm LoRa based telemetry and radio link for remote controlled vehicles
GNU General Public License v3.0
337 stars 75 forks source link

Bug: No characters allowed in Bind Phrase via CLI. #34

Closed vrquaeler closed 2 years ago

vrquaeler commented 2 years ago

Assuming I am not totally wrong with the CLI. While testing different targets I found a minor issue:

Changing the Pass Phrase via CLI. I am not allowed to enter character's in the pass phrase via CLI.

Observed behavior: Enter: p bind_phrase = wle5jc; Response: err: invalid value

Expected behavior: Enter: p bind_phrase = wle5jc; Expected response: Bind Phrase = wle5jc

Entering digit's or #-._ works as it should. For example: Enter: p bind_phrase = 123456; gives the expected response: Bind Phrase = 123456

Way to reproduce the effect: see "Observed behavior". Tested on tx-R9M, tx-R9MX, tx-WIO-E5-mini.

Additional info: On the target tx-R9M the Bind Phrase can be changed (incl. characters) using the lua-script and saved as it should. The tests are done on Win10 and Linux PC's using the language setting: US-English UTF-8.

olliw42 commented 2 years ago

@vrquaeler oh, indeed MANY THX!! this was actually an interesting one LOL pl try out the latest, v0.3.05, should all be working now

vrquaeler commented 2 years ago

@olliw42

Have tried v0.3.05 ... Everything is working as it should. Now running the CLI i can do everything I want to do. :+1: :+1: Thanks for the fast fix.

olliw42 commented 2 years ago

many thx for the feedback great to hear