search

olliw42 / mLRS

2.4 GHz & 915/868 MHz & 433 MHz/70 cm LoRa based telemetry and radio link for remote controlled vehicles
GNU General Public License v3.0
298 stars 70 forks source link

bug fix: E5Grove, swap UART #43

Closed vrquaeler closed 1 year ago

vrquaeler commented 1 year ago

Hi Olli,

Here is the bug fix for the Grove E5 module as receiver. This should fix issue #42. The Serial port has pointing to the wrong UART.

PS: I am the only one experimenting with this?

olliw42 commented 1 year ago

MANY thx, sir!

I am the only one experimenting with this?

I have one module and used it when I did the code, but I really haven't used it since then. I'm sure it was working, but I would not rule out that I screwed things up when I prepared the merge. So, currently, you indeed might be the only one :)

I will double check ASAP.

olliw42 commented 1 year ago

you are absolutely correct, is on PB6/7

you need to do the change also in line 51: #define UARTC_USE_UART1_REMAPPED // debug // also UART2

can you update the PR? if not I'll do after having merged, just pl tell

vrquaeler commented 1 year ago

Hi Olli,

Thanks for the confirmation. Please feel free to update the PR. You are right, the debug port (Line 51) should be set to UART1, too.
I would like to update the the PR, but unfortunately I have screwed my "git" (again)....

Update: fixed my git issues. Now the PR should be ready ....

olliw42 commented 1 year ago

MANY thx, sir, This is very much appreciated :)