Closed jlpoltrack closed 1 year ago
this looks well done, just a pititesse
I would however wish we could get more testing/confirmation on this, before merging, no idea how to achieve that though
let's try to get a feedback from the original author of the sx126x lib
@Imen-D: can you maybe comment on this PR. Is this what one should do? Thx.
Hi Guys,
Image calibration is part of calibration process when device startup whether from POR or sleep. mLRS didn't make any command to chip to sleep. So we can focused on POR. Our lib will wait this process when startup and will be done before we setup TCXO, CMIIW. As mLRS keep develop and changing, hence we can use different frequency range, i.e E22 900M can use 915 or 868 band, and sx1268 with default 470~510 which is not our common frequency (433), so we must do image calibration.
@Imen-D many thx for chimming in :) So, you confirm what ImageCalibration shoudl be done.
Could you pl also have a look at the code which @jlpoltrack is suggesting in this PR, and confirm/disconfirm if it is in the correct place?
To me it makes perfect sense as it comes after having set the TXCO, but it would be great to get additional confirmation, if possible, if it's done correctly.
@olliw42, @jlpoltrack , yes it is good for me, I'm in
@jlpoltrack @Imen-D
ok, so I'm merging :)
MANY THX folks!
Added based on datasheet 9.2.1. Supposed to help Rx performance - saw no real change in RSSI on the bench with and without.