olliw42 / mLRS

2.4 GHz & 915/868 MHz & 433 MHz/70 cm LoRa based telemetry and radio link for remote controlled vehicles
GNU General Public License v3.0
295 stars 67 forks source link

Add support for M5STAMP_C3U_MATE configured for R9M #72

Closed brad112358 closed 1 year ago

brad112358 commented 1 year ago

This works every bit as cleanly with the R9M as the M5STAMP PICO does. Just 4 easy to solder thru-hole pins. And yes, it's easier to program. Just hold down the central button when plugging it in to USB

20230419_182313

olliw42 commented 1 year ago

GREAT!

just two inline observation

olliw42 commented 1 year ago

so, if I understand the 5V issue, the procedure is to take off the stamp, connect to usb and flash, and then to put it back on, right?

I would wish also the sbus pin would be connected to one of the esp gpio's, but not in reach LOL

brad112358 commented 1 year ago

so, if I understand the 5V issue, the procedure is to take off the stamp, connect to usb and flash, and then to put it back on, right?

Correct.

vrquaeler commented 1 year ago

I love seeing more options to connect the R9M to the GCS computer.

I would wish also the sbus pin would be connected to one of the esp gpio's, but not in reach LOL

May I ask what the purpose of connecting the sbus bin to the ESP32 could be? I did not get it.

olliw42 commented 1 year ago

May I ask what the purpose of connecting the sbus bin to the ESP32 could be?

I'm thinking about a way to configure the esp from the tx module. This would e.g. allow to set the wifi credentials, or the baudrate, and such, in the esp from the lua,cli,display. In order to tell the esp when the serial trafic via the uart is not data but for configuration, the approach I have in mind is to set one pin to e.g. zero.

brad112358 commented 1 year ago

In order to tell the esp when the serial trafic via the uart is not data but for configuration, the approach I have in mind is to set one pin to e.g. zero.

I suppose this could be done neatly enough by carefully trimming a double wide female header connector or using the existing connector with some glue and soldering a wire to the extra pin. But this significantly complicates the build, Instead, what about a software solution where the transmitter always sends the configuration at power on. Requiring an extra power cycle after configuration changes should be acceptable I'd think.

olliw42 commented 1 year ago

I was sure thinking about a software only solution, would be just so much nicer, but there was an issue which I don't recall which made me get back to the gpio thing your other PR, when we have syncing to silent gaps, may aleviate my older issues however your idea of doing config only at power up is probably a very good one, the tx and rx are power cycled on "store" anyways, and one could deal with the esp equally as the receiver is dealt with ... this sounds indeed like a very possible approach, I will keep it in mind, thx

olliw42 commented 1 year ago

NICE !!

may I ask you for anorther slight change:

given that your two additions are clearly not canonical but targeted for use with the R9M, could you please change the name of the defines to MODULE_M5STAMP_PICO_FOR_FRSKY_R9M MODULE_M5STAMP_C3U_MATE_FOR_FRSKY_R9M

two further ideas, not for this PR, but I just like to grab the occasion:

brad112358 commented 1 year ago

I think the C3 Mate should also be a great candidate, and work essentially like the C3U mate, shouldn't it? I wonder if one shouldn't add a MODULE_M5STAMP_C3_MATE_FOR_FRSKY_R9M, in a follow up PR.

Shouldn't the same binary work? Perhaps add a comment rather than another target define.

Can't we use the C3/C3U also as serial inverter

Yes, but once we get the ELRS firmware install method working, that method is even easier than the bootloader in the case of the R9M

olliw42 commented 1 year ago

Shouldn't the same binary work? Perhaps add a comment rather than another target define.

I don't know but wouldn't think so. The C3 has a usb-ttl adapter, the C3U uses native usb.

Yes, but once we get the ELRS firmware install method working, that method is even easier than the bootloader in the case of the R9M

yeah, if that will work out, if not it could be an option

MANY THX! will merge now :)