olliw42 / mLRS

2.4 GHz & 915/868 MHz & 433 MHz/70 cm LoRa based telemetry and radio link for remote controlled vehicles
GNU General Public License v3.0
295 stars 67 forks source link

IN 866 Fixes #79

Closed jlpoltrack closed 1 year ago

jlpoltrack commented 1 year ago
olliw42 commented 1 year ago

yes, config_i can be only one of these values

therefore "not 433_MHZ or not 866_MHZ_IN" will be always true and the condition is obsolete

what we want is that the code piece is not called if 433_MHZ or 866_MHZ_IN, i.e., "not (433_MHZ or 866_MHZ_IN)" which is equal to "(not 433_MHZ and not 866_MHZ_IN)"

:)

jlpoltrack commented 1 year ago

Now I see - updated :)

olliw42 commented 1 year ago

have you tested it? I'm inclined to merge :)

jlpoltrack commented 1 year ago

I only tested that it compiles. We can give heads up on Discord for further testing :)

olliw42 commented 1 year ago

we both think it's correct, right? maybe I'm just hilarious with asking for a test :)

jlpoltrack commented 1 year ago

Hehe - alright. Flashed to E5 Mini:

image

olliw42 commented 1 year ago

MANY THX !!!! merging