olliw42 / mLRS

2.4 GHz & 915/868 MHz & 433 MHz/70 cm LoRa based telemetry and radio link for remote controlled vehicles
GNU General Public License v3.0
295 stars 67 forks source link

SX128x OTA times don't match calculator? #81

Closed jlpoltrack closed 1 year ago

jlpoltrack commented 1 year ago

SX128x | 50 Hz shows OTA of 7892 uS but calculator shows 8128?

https://github.com/olliw42/mLRS/blob/main/mLRS/Common/sx-drivers/sx128x_driver.h#L57

image

SX126x matches calculator, e.g. 31 Hz:

https://github.com/olliw42/mLRS/blob/main/mLRS/Common/sx-drivers/sx126x_driver.h#L43

image

jlpoltrack commented 1 year ago

Answering myself, mLRS uses the 'LI' Long Interleaving Coding Rates which align:

image

olliw42 commented 1 year ago

exactly! it's the reason it uses LI. I actually wonder if not using LI would give some benefit with the crc1 mechanism, but for now it's as it is :)