olliw42 / mLRS

2.4 GHz & 915/868 MHz & 433 MHz/70 cm LoRa based telemetry and radio link for remote controlled vehicles
GNU General Public License v3.0
295 stars 67 forks source link

Main branch fails to compile? #95

Closed jlpoltrack closed 1 year ago

jlpoltrack commented 1 year ago

Tried to build and compile from main today:

image

Got a bunch of errors when compiling around ST drivers missing. (I followed the usual steps with running 'run_setup.py' and had the correct workspace in STM32CubeIDE)

Had to use this commit in order to compile:

image
olliw42 commented 1 year ago

ok

I indeed made quite substantial changes to the "build system". The main driving force is to have an aoutomated way to set compile flags.

it also gets rid of a thing which really started to massivly annoy me, namely that all the ST drivers were stored in each target (which blew up the download but also required massive comits)

can you please go to the tools folder and run run_copy_st_drivers.py. This should solve the issue, hopefully. I think the bug is that this now needs to be also called from setup.py

jlpoltrack commented 1 year ago

That script fails to run for me 'The system cannot find the file specified'

image

I do see files in that location: image

olliw42 commented 1 year ago

this is not windows, right?

jlpoltrack commented 1 year ago

Windows 11

olliw42 commented 1 year ago

then I'm surprised... and clueless ... I was thinking that the issue are these lines https://github.com/olliw42/mLRS/blob/main/tools/run_copy_st_drivers.py#L25-L26, but they work for me, on win ...

do you maybe have to call it with python3?

jlpoltrack commented 1 year ago

Silly me, I had a space in my folder name 'mLRS Dev' which this script didn't like, changing to 'mLRSDev' works.

Confirming that I can compile successfully too after run_copy_st_drivers.py

olliw42 commented 1 year ago

great!

and not so great ... it should work with blanks ... I will check what I find on this

but it needs to be called also from run_setup, that's clearly a bug you uncovered :D

olliw42 commented 1 year ago

it now should work

THX for discovering these issues!

jlpoltrack commented 1 year ago

Perfect, latest commit resolves this issue.

olliw42 commented 1 year ago

it should also work with blanks now.

THX, this was very helpful.

jlpoltrack commented 1 year ago

Just confirming that it works with blanks/spaces too.

olliw42 commented 1 year ago

:+1: