ollm / OpenComic

Comic and Manga reader, written with Node.js and using Electron
GNU General Public License v3.0
872 stars 76 forks source link

[Bug]: Last page / Next chapter button on panel has wrong state if last page is small #195

Open dajotim937 opened 7 months ago

dajotim937 commented 7 months ago

Preflight Checklist

OpenComic Version

1.1.0 (well, I'm using your custom test build for me)

Operating System

Win10, 22H2, build 19045

Steps to reproduce

  1. Webtoon with last page smaller than current vertical size of reading area.
  2. Webtoon reading view.
  3. Click either last page button or click on last page from left side scroll panel

Expected Behavior

Button should change to "next chapter" since there nothing left to scroll (full last page fit into vertical size of reading area)

Actual Behavior

App showing "last page" button like there is something left to scroll. Clicking on it scroll webtoon up a bit, clicking again scroll to the end and changing button to "next chapter".

Error message

No response

Additional Information

No response

Sample file

No response

dajotim937 commented 7 months ago

Fixed in test build.

dajotim937 commented 7 months ago

Related: boundary situation, if you scroll last chapter with arrow key and last page is small last page/next chapter will have wrong state. Not that it doesn't matter but still.

And suggestion: open manga page after reading last chapter and clicking next chapter button.

dajotim937 commented 7 months ago

Related:

https://github.com/ollm/OpenComic/assets/96221151/502e9d53-88f3-4a03-94c2-677ca648be90

ollm commented 5 months ago

Can you confirm if the error still occurs in latest version v1.2.0?

dajotim937 commented 5 months ago

Original bug from first comment is fixed, related bug from https://github.com/ollm/OpenComic/issues/195#issuecomment-1916326113 is not fixed.

Additional info: bug from video is happened only when there is next chapter. If there isn't, it scroll to the end as intended.

ollm commented 5 months ago

Fixed in cae6b6c65222d528705e44f6eee08feab3ec9adb

Build: https://mega.nz/file/nbQUlDIJ#iVhuBj0ES_H4VUCR0Kl36l980bmSBkYmKKmNpt0anpA

dajotim937 commented 5 months ago

Looks like I can't reproduce it anymore.