search

ollm / OpenComic

Comic and Manga reader, written with Node.js and using Electron
GNU General Public License v3.0
883 stars 78 forks source link

[Feature Request]: Image Transitions #225

Open Laughingcow opened 5 months ago

Laughingcow commented 5 months ago

Preflight Checklist

Describe your suggested feature

Is it possible to add image transitions such as page turn and fades? I want to have a proper feel of reading a comic book and having that effect makes a difference. GonVisor has a whole slew of these but is temperamental and doesn't read all file formats.

Another bit is having a SoundFX play during the transition. Honeyview had this before it was removed where a page turning sound would play everytime a page was turned.

Additional Information

No response

Sample file

No response

ollm commented 5 months ago

I'll see if it's possible to do, the fading effect is easy, but the transitions that simulates a page turn may be more complicated.

Laughingcow commented 5 months ago

It isn't just the effect itself but the speed on which is goes. Gonvisor has the ability to set the speed on which the transition goes. I have no idea how this works from a technical perspective but it is possible. I highly recommend looking into GonVisor and how it handles all this. Screenshot 2024-04-30 085253 Screenshot 2024-04-30 085258 Screenshot 2024-04-30 085207

Could help you figure things out.

ollm commented 5 months ago

I've looked at it a bit to see how the animation works, and the one it uses is not very complicated, although I would like to try to make it look more like a real page, so I will continue investigating if it is possible to do so.

Regarding speed, you can currently adjust in OpenComic.

Captura desde 2024-04-30 18-58-29

Laughingcow commented 5 months ago

Good to know.

If you can get it to work, the next thing would be getting sounds for the transitions. There's plenty of sounds on youtube and other places. https://www.youtube.com/watch?v=tAADqtTtT7k

The idea is that during the page transition, you can have it play a small sound cue if you wanted. Again, it helps with the immersion.

ollm commented 5 months ago

I will also take it into account for this feature, if there is any other type of sound that you would like there to be when turning the page, you can also send me an example video/audio.

Laughingcow commented 4 months ago

Nothing comes to mind but I imagine others might think otherwise. I think a better solution than adding a bunch of sounds is to allow users add custom sounds if they want. That would save you a headache in the long run.