search

ollm / OpenComic

Comic and Manga reader, written with Node.js and using Electron
GNU General Public License v3.0
909 stars 78 forks source link

Not generating preview pictures consistently. #51

Closed EliCodesForFun closed 1 year ago

EliCodesForFun commented 4 years ago

OpenComic_B80AmTVnud

The images are contained within a subfolder within the zip, if this helps diagnose. This is very common for comics. Pics attached. WinRAR_ubYYR9skoR WinRAR_f4SyFAK8Ro

Almost all my zipped comics are like this, but the behavior in the app is inconsistent. After I open the zip, I do get the preview image, but it's very small as you can see.

I think the issue might have to do with the size of the first .jpg or .png in the folder, or its total size. It seems to be that any zip file over 50MB won't preview.

ollm commented 4 years ago

The decompression of files when making thumbnails is limited to 50 MB, this is due to the fact that the App does not currently delete the decompressed files after making the thumbnails, the files are kept in the tmp folder until the PC is restarted / shut down, I will add soon an option to increase this limit and I will make the unzipped files delete after generating the thumbnail.

https://github.com/ollm/OpenComic/blob/0bbdcfd25bea692b4958c05ae28006503bc179e6/scripts/dom.js#L670

The problem with the small thumbnail is because currently 4 images are displayed, as there is only one, the others appear in white, I will have to add an option so that it can be configured in large (1 Image) or in small (4 Images).

Screenshot

EliCodesForFun commented 4 years ago

The decompression of files when making thumbnails is limited to 50 MB, this is due to the fact that the App does not currently delete the decompressed files after making the thumbnails, the files are kept in the tmp folder until the PC is restarted / shut down, I will add soon an option to increase this limit and I will make the unzipped files delete after generating the thumbnail.

The problem with the small thumbnail is because currently 4 images are displayed, as there is only one, the others appear in white, I will have to add an option so that it can be configured in large (1 Image) or in small (4 Images).

If you fix these two things you're like my hero. Some hotkeys could be pretty cool too, like for going to the next or previous folder, but I like the interface. It would also be very ideal if your "scroll down" through your library could be saved (persist) when hitting Back from viewing a comic zip file, so that you could more easily go from 1 zip file to the next. Currently you'd have to scroll all the way back down. Some people might have large collections of zipped art they're checking through (like me).

ollm commented 4 years ago

Some hotkeys could be pretty cool too, like for going to the next or previous folder, but I like the interface.

Do you mean that if you are, for example, in 02.zip, go to 03.zip or 01.zip without having to go back?

It would also be very ideal if your "scroll down" through your library could be saved (persist) when hitting Back from viewing a comic zip file, so that you could more easily go from 1 zip file to the next. Currently you'd have to scroll all the way back down. Some people might have large collections of zipped art they're checking through (like me).

I will add this also as a pending to do.

ollm commented 4 years ago

The previous scroll is now kept when navigating back 539ac33502876a2ee83f4d54fd5b85c6f8df220e

EliCodesForFun commented 4 years ago

Do you mean that if you are, for example, in 02.zip, go to 03.zip or 01.zip without having to go back? Precisely, just go right down the list of zips/rars in the folder by ABC or Numerical order. It's good for quick skimming, finding favorite scenes from a comic, etc. It's a feature integrated into the app HoneyView, and it's one of the main reasons I use it.

The previous scroll is now kept when navigating back 539ac33

That's awesome, you're a beast, bro. I hope these updates are making the app even more user-friendly for everyone, so that it can be a lite and versatile comic viewer replacement. With the few changes implemented, it'd already be more usable for me than other big dedicated comic reader apps I've used - ComicRack, CDisplay. They take too a bit too much for the folder setup and/or have a lot of jank when switching between comics, in my experience. Interface is also a bit WindowsXP-ish too, so your use of the JS libraries is great.

ollm commented 1 year ago

Closed as completed in c1259bb512983751fe41304c7c642966b204aea1 and available in v1.0.0-beta.1

Feel free to reopen the issue if you find any bugs.