ollm / OpenComic

Comic and Manga reader, written with Node.js and using Electron
GNU General Public License v3.0
927 stars 79 forks source link

Suggestions to consider #85

Open mspykerez opened 3 years ago

mspykerez commented 3 years ago

Coming from another app and with my limited experience using OpenComic I’d like to give some feedback in order to improve this app as follows:

As a closing thought, what are the image filters or scaling algorithms OpenComic is using? I’m asking because I’ve notice a slight downgrade on image quality when using OpenComic compared to others. Sure OpenComic is fast on opening and switching images but I would not mind losing some speed for some increased quality.

shrublet commented 3 years ago

Have a couple of additions I'd also like to throw in and not sure if it's better having two separate issues so I'll put them here for now.

Besides that, I'd like to second a lot of what mspykerez has said and believe their suggestions are incredibly valuable features. Custom keybinds, search, and fixed zoom are especially useful from a usability standpoint.

ollm commented 1 year ago

Most of the following features are now available in the beta version of the app (v1.0.0-beta.3)

Provide a portable version for Windows.

The portable version is available in beta version

Ability to make our own custom keybinds/hotkeys/shortcuts.

Allow for quick drag-and-drop files/folders into the app window to open them (perhaps even consider using a modifier key like CTRL to permanently add the files/folders into the app instead of just opening them).

Allow searching within the app.

When a compressed file instead of having all the images on its root (like ‘images.rar/images.png’) contains just 1 folder with images inside (like ‘images.rar/random-folder-name/images.png’), currently if you add such a file to your library you will need to ‘browser twice’ in order to get to the images because OpenComic will add the entire path. I suggest OpenComic to ignore the ‘images.rar’ from the path and only add the ‘random-folder-name/images.png’ to the library, that way when we go to our library we will not see and have to open a ‘images.rar’ folder that will in turn show another ‘random-folder-name’ which is the one to have the images inside, instead we will only see and have to open a ‘random-folder-name’ to start immediately seeing the images inside of it! This behavior however is welcome when you add folders and not compressed files because you can for example add to OpenComic a ‘folder1’ which contains another ‘folder2’ with some images in it and later on decide to add another ‘folder3’ which also contain some images into the ‘folder1’ path. In this particular case OpenComic would detect and pick up the new ‘folder3’ that was added into the already existing ‘folder1’ path displaying both the ‘folder2’ and ‘folder3’ under the ‘folder1’ path, so you would click the ‘folder1’ displayed in your library and then it will show you 2 different folders (‘folder2’ and ‘folder3’) that you can navigate to to see their respective image files.

Introduce ‘fixed zoom’ rules that images would follow at all times like 'fit width' 'fit height' ''fit to window' ‘show original image size’ or even let us enter a manual Zoom % value that we can work with to alter the original image size.

Let the user choose the size of the cache that OpenComic can use, and allow to manually clean it with a push of a button or automatically on a scheduled basis or when closing the app.

As a closing thought, what are the image filters or scaling algorithms OpenComic is using? I’m asking because I’ve notice a slight downgrade on image quality when using OpenComic compared to others. Sure OpenComic is fast on opening and switching images but I would not mind losing some speed for some increased quality.

OpenComic does not use any image scaling algorithm, it simply sets the image size and Chromium/Electron resizes it, although I have made some changes to zooming to prevent Chromium/Electron from blurring the image.

You can see all changes in the Changelog 📝

Have a couple of additions I'd also like to throw in and not sure if it's better having two separate issues so I'll put them here for now.

It's best to open a ticket for every feature/bug request (Even for those of @mspykerez), since otherwise I can't close the issue until everything is implemented or discarded.

ollm commented 9 months ago

Favoriting folders and a favorites collection (could be put on the sidebar since it's a little empty with just Comics/Language)

I add support for favorite label in v1.1.0