ollo69 / ha-smartthinq-sensors

HomeAssistant custom integration for SmartThinQ LG devices configurable with Lovelace User Interface.
Apache License 2.0
1.15k stars 159 forks source link

AC display light switch not working #475

Closed gabi1324 closed 11 months ago

gabi1324 commented 1 year ago

Describe the bug Hello! I have a problem with the display light on an S09ET AC unit. The switch is always off and if I toggle it the unit beeps but doesn't do anything. I can control the light from the remote but not from the LG app.

Expected behavior control the display light from HA

Screenshots If applicable, add screenshots to help explain your problem.

Environment details:

Output of HA logs Paste the relevant output of the HA log here.

Additional context Add any other context about the problem here.

ollo69 commented 1 year ago

Please attach diagnostic

gabi1324 commented 1 year ago

config_entry-smartthinq_sensors-06a774f58ee56ffb645ea7e4f785c74f.json.txt

SN0WTR00PER commented 1 year ago

Same thing for me... Its not working. Here my diag file config_entry-smartthinq_sensors-fc6f45dbc8d08d7c44080f6b4f49c7f5.json.txt

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days.

gabi1324 commented 1 year ago

Hi! Are there any updates on this issue?

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days.

gabi1324 commented 1 year ago

Still an issue.

vincentwolsink commented 1 year ago

I also have issues with S09ET and S12ET (RAC_056905_WW-RAC) airco's. The display light button is present for both ACs. When toggling the button the ACs do make a beep sound, but nothing happens.

See also #515

vifrost commented 1 year ago
  1. download statistic information ( device informaion )

image

  1. find "airState.lightingState.displayControl"
  2. check number of @AC_LED_OFF_W and @AC_LED_ON_W
  3. edit ac.py ( /root/config/custom_components/smartting_sensors/wideq/devices/ac.py )
  4. working right ON/OFF

image

gabi1324 commented 1 year ago

Hi! I tried modifying ac.py but it doesn't work. The AC unit beeps and doesn't do anything. In the diagnostic file, I have "airState.lightingState.displayControl": 0.0 . I think this modification works for other AC models, but it isn't working for S09ET and other different variations.

SiboutVanLoo commented 1 year ago

Hi there, tried it to, but does'nt help, but seems to point in the right direction. Changed the setting to 11 and 12, like you suggested, and now the 'light-state' is displayed correctly, but the command does'nt seem to get thru. If i turn it off by remote controle, it shows "off" after a few minutes, 5 i guess, like the code suggests. So that's a good thing, so any ideas why the "command" aspect seems to stay behind? Was looking in sections further ahead in the code, mentioning "display", but my python knowledge seems to be lacking, and i would'nt want to wreck anything. Thanks!

jackbrown1993 commented 1 year ago

Also hitting this issue with the below model, unit beeps but display remains on.

RAC_056905_WW-RAC (AC) Firmware: clip_hna_v1.9.188

SiboutVanLoo commented 1 year ago

Ok, This is the return information of the AC unit.

"airState.lightingState.displayControl": 1.0, "airState.wDir.hStep": 3.0, "mid": 6982764.0, "airState.energy.onCurrent": 60.0, "airState.wMode.airClean": 1.0, "airState.quality.sensorMon": 0.0, "airState.tempState.target": 25.0,

Above is Display light off (From aircon data.)

"airState.lightingState.displayControl": 0.0, "airState.wDir.hStep": 3.0, "mid": 7716930.0, "airState.energy.onCurrent": 152.0, "airState.wMode.airClean": 1.0, "airState.quality.sensorMon": 0.0, "airState.tempState.target": 24.0,

This was display ON

Below is "airclean data "on" from unit

"airState.lightingState.displayControl": 0.0, "airState.wDir.hStep": 3.0, "mid": 179596276.0, "airState.energy.onCurrent": 146.0, "airState.wMode.airClean": 0.0, "airState.quality.sensorMon": 0.0, "airState.tempState.target": 23.0,

Below is airclean data "off" from unit.

"airState.lightingState.displayControl": 0.0, "airState.wDir.hStep": 3.0, "mid": 179391791.0, "airState.energy.onCurrent": 146.0, "airState.wMode.airClean": 1.0, "airState.quality.sensorMon": 0.0, "airState.tempState.target": 23.0,

Here is the airclean mapping data from unit.

          "airState.wMode.airClean": {
            "data_type": "enum",
            "default": "0",
            "value_mapping": {
              "0": "@AC_MAIN_AIRCLEAN_OFF_W",
              "1": "@AC_MAIN_AIRCLEAN_ON_W"

Below is the mapping data of the display.

"airState.lightingState.displayControl": { "data_type": "enum", "default": "0", "value_mapping": { "0": "@RAC_LED_ON", "1": "@RAC_LED_OFF", "2": "@NON", "3": "@NON", "4": "@NON", "5": "@NON", "6": "@NON", "7": "@NON", "8": "@NON", "9": "@NON", "10": "@NON", "11": "@AC_LED_OFF_W", "12": "@AC_LED_ON_W", "13": "@AC_LED_AUTO_W"

Here is the python command setting code.

ADD_FEAT_POLL_INTERVAL = 300 # 5 minutes

LIGHTING_DISPLAY_OFF = "0" LIGHTING_DISPLAY_ON = "1"

MODE_OFF = "@OFF" MODE_ON = "@ON"

MODE_AIRCLEAN_OFF = "@AC_MAIN_AIRCLEAN_OFF_W" MODE_AIRCLEAN_ON = "@AC_MAIN_AIRCLEAN_ON_W"

"airclean" works fine, but display does not.

Changing 1 & 0 to LIGHTING_DISPLAY_OFF = "@RAC_LED_OFF" LIGHTING_DISPLAY_ON = "@RAC_LED_ON" Or LIGHTING_DISPLAY_OFF = "@AC_LED_OFF_W" LIGHTING_DISPLAY_ON = "@AC_LED_ON_W" Or LIGHTING_DISPLAY_OFF = "1.0" LIGHTING_DISPLAY_ON = "0.0" Or LIGHTING_DISPLAY_OFF = 1 LIGHTING_DISPLAY_ON = 0 Or LIGHTING_DISPLAY_OFF = 1.0 LIGHTING_DISPLAY_ON = 0.0

Did not work. Restarted HA every change, reloaded the thinq integration.

filipef101 commented 1 year ago

The homebridge lge plugin works as expected, could be worth taking a look at what they are doing

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days.

SiboutVanLoo commented 1 year ago

Bump

ollo69 commented 1 year ago

The problem with controls is that I need the right command to use. Someone should use a mitm connetion to capture this. There is a good guide to so this, as reported here. If someone can do this, that I can try to fix this issue.

jackbrown1993 commented 1 year ago

@ollo69 There isn't an option for 'display light' in the app, there is a button on the physical remote control though which works.

ollo69 commented 1 year ago

There isn't an option for 'display light' in the app, there is a button on the physical remote control though which works.

But I suppose that remote use infrared, doesn't it? So this should not be possible to implement at all. The only way that is that someone with an AC device play with the integration code here, trying to find a command that control the light. In case I will be happy to implement in a new release.

jackbrown1993 commented 1 year ago

Yes, the remote is infrared.

elpigeondindo commented 1 year ago

There isn't an option for 'display light' in the app, there is a button on the physical remote control though which works.

But I suppose that remote use infrared, doesn't it? So this should not be possible to implement at all. The only way that is that someone with an AC device play with the integration code here, trying to find a command that control the light. In case I will be happy to implement in a new release.

I can try but I don't know how to code in python too much. If someone tells me what to do I can try

Coubi028 commented 1 year ago

@ollo69 There isn't an option for 'display light' in the app, there is a button on the physical remote control though which works.

Yes I tried too and there is no option to activate/deactivate the light in the LG Thinq androïd App...

elpigeondindo commented 1 year ago

But that does not mean that the option does not exist in the API

Coubi028 commented 1 year ago

Yes I'm agree but it will be more difficult to find the command.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 year ago

This issue was closed because it has been stalled for 7 days with no activity.

dougiteixeira commented 12 months ago

Hey @ollo69, I saw that this feature was removed in the v0.35.0 version due to several open issues reporting that it doesn't work... but here it worked perfectly.

I want to see with you whether it is acceptable to implement this as a service so that users who have compatible equipment can continue to use the feature to turn the display light on and off. I understand that making it available as a service will reduce complaints that it doesn't work due to the non-existence of the entity, but they can still happen, so in the documentation I would make it clear that it is not compatible with all available models.

What do you think?

ollo69 commented 12 months ago

@dougiteixeira,

you are the first reporting that the switch is working. Can you please share your integration diagnostic so that I can try to find a way to identify devices that support this feature?

Thanks👍

dougiteixeira commented 12 months ago

With the conditioner turned off, the display remains off even with the switch on, but when the conditioner is turned on, the display follows the switch configuration.

Integration Diagnostics: smartthinq_sensors-cc226181134f606f36942198ac83891b-Ar Quarto-731c136139db78a958b86733d019cdd3.json (5).txt

Debug logs during commands: home-assistant-smartthinq-sensors.log

ldotlopez commented 12 months ago

Hi @ollo69 ,

I came here from the notice in the update README: "Remove light display switch entity for AC (generally not working, see #475)"

That switch is working for me too, and I'm using it in some automations.

Here are my diagnostics, feel free to ask anything. smartthinq_sensors-8163e2cb1a99ab2500664e17e12b061f-Aire acondicionado habitación-1b16701a9d97af16e21eb981de606784.json.txt

ollo69 commented 12 months ago

The main reason to disable the switch was to find you guys😊. I will take a look to this on next days and I'll give you a feed-back.

rodolfomachado commented 12 months ago

Hi guys, +1 to say that The switch was working fine. Btw, I use it a lot. But it only works after the ac in ON. If the AC is off will just make a sound. If you need any diagnostic I can send you

pedropaislopes commented 12 months ago

Hi! +1 here! Display switch working fine for 7 AC units on the 0.34.0 version. But for 2 of them the display logic is inverted - off on HA display on, on unit. I can open a new issue related to this inverted behavior once display switch is back!

ollo69 commented 12 months ago

If you need any diagnostic I can send you

Yes please, more diagnostics I have for working device better I can identify working devices. Till now I understood that switch work only when AC is on.

ollo69 commented 12 months ago

But for 2 of them the display logic is inverted

Please provide diagnostics for both devices type, 1 with correct logic and 1 with inverted logic. Thanks.

rodolfomachado commented 12 months ago

error_log.txt As someone said, it does not work when it's off but if you turn it on it will follow the switch

selectcarleasing commented 12 months ago

Just to add, on mine when the unit is on this switch will make the unit make a noise but nothing happens with the light.

From: rodolfomachado @.> Sent: Thursday, November 2, 2023 10:16 AM To: ollo69/ha-smartthinq-sensors @.> Cc: Subscribed @.***> Subject: Re: [ollo69/ha-smartthinq-sensors] AC display light switch not working (Issue #475)

https://github.com/ollo69/ha-smartthinq-sensors/files/13237486/error_log.txt This message originated from outside your organization

https://github.com/ollo69/ha-smartthinq-sensors/files/13237486/error_log.txt https://github.com/ollo69/ha-smartthinq-sensors/files/13237486/error_log.txt


error_log.txthttps://github.com/ollo69/ha-smartthinq-sensors/files/13237486/error_log.txt As someone said, it does not work when it's off but if you turn it on it will follow the switch

— Reply to this email directly, view it on GitHubhttps://github.com/ollo69/ha-smartthinq-sensors/issues/475#issuecomment-1790442276, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUPXSBB4R7CSDQZHNHV3MPDYCNXELAVCNFSM6AAAAAATV4TS4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJQGQ2DEMRXGY. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>

mukaschultze commented 12 months ago

Just to add my two cents here, the switch works for me when the unit is both on and off, although the switch is inverted (on turns the light off, and vice versa). Model number is S4NW09AA31B.EB2GAMZ. I'll see if I can get the diagnostic data later.

rodolfomachado commented 12 months ago

Previously I sent debug logging, now The diagnostics. For both ACs The switch were working as I said smartthinq_sensors-b841fba9bca1284b3335c14ff0eed2bc-Ar da Suíte-2f5ba8c6fc513baf97b91265cd24c5bd.json smartthinq_sensors-b841fba9bca1284b3335c14ff0eed2bc-Ar da Lara-bc88583922fc5b9b571aa319a6845856.json

ldotlopez commented 12 months ago

Just to add, on mine when the unit is on this switch will make the unit make a noise but nothing happens with the light.

But it only works after the ac in ON. If the AC is off will just make a sound.

Same for my unit.

ollo69 commented 12 months ago

@All,

I just restored the switch with last release, adding some more controls in the way that the current status is detected. For now I do not consider the AC status (on/off) so that anybody can test switch behavior. In any case looking at the attached diagnostic files the switch had to be reversed for all in previous versions, I would be surprised if it didn't. Please report here results with your devices using last release, more details you will provide better will be.

dougiteixeira commented 12 months ago

@ollo69, I tested version 0.35.1 here, but the swicth is inverted in relation to the real status of the display.

Diagnostic files:

dougiteixeira commented 12 months ago

For now I do not consider the AC status (on/off) so that anybody can test switch behavior.

I believe that the switch should remain active regardless of the conditioner being turned on, as the configuration will be changed in the same way, but the physical display will only be turned on if the conditioner is in operation and the switch is active.

In other words, I can change the setting regardless of the mode the conditioner is in (on/off).

And when we use the remote control, this behavior occurs as well.

SiboutVanLoo commented 12 months ago

I see a "Bell sound" section... Interesting! 😃 But off topic, thanks for looking in to it @ollo!

Op do 2 nov 2023 22:15 schreef dougiteixeira @.***>:

@ollo69 https://github.com/ollo69, I tested version 0.35.1 here, but the swicth is inverted in relation to the real status of the display.

Diagnostic files:

— Reply to this email directly, view it on GitHub https://github.com/ollo69/ha-smartthinq-sensors/issues/475#issuecomment-1791546971, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFCKJFLPCITGIYNL6U636P3YCQEN7AVCNFSM6AAAAAATV4TS4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJRGU2DMOJXGE . You are receiving this because you commented.Message ID: @.***>

ollo69 commented 12 months ago

but the swicth is inverted in relation to the real status of the display.

I'm not understanding how to determinate this. Let's wait for others feedback.

rodolfomachado commented 12 months ago

Well, I'm not at home till Sunday to test but I can say that was usefull to have the switch even when the AC was off. Another point, to me the switch was not inverted, so no need to invert the logic. The way was before was perfect to me

ollo69 commented 12 months ago

It should be great have diagnostic from someone that say that logic is inverted, as @mukaschultze or @pedropaislopes

mukaschultze commented 12 months ago

@ollo69 here you go, diagnostic data and logs when toggling the switch

ac-off-light-off.json ac-off-light-on.json ac-on-light-off.json ac-on-light-on.json toggling-light.log

pedropaislopes commented 12 months ago

Hi! Unfortunately I’m not at home until Saturday. When back home I can provide you with all logs!

Em 2 de nov. de 2023, à(s) 19:08, Samuel Schultze @.***> escreveu:

@ollo69 https://github.com/ollo69 here you go, diagnostic data and logs when toggling the switch

ac-off-light-off.json https://github.com/ollo69/ha-smartthinq-sensors/files/13245030/ac-off-light-off.json ac-off-light-on.json https://github.com/ollo69/ha-smartthinq-sensors/files/13245031/ac-off-light-on.json ac-on-light-off.json https://github.com/ollo69/ha-smartthinq-sensors/files/13245032/ac-on-light-off.json ac-on-light-on.json https://github.com/ollo69/ha-smartthinq-sensors/files/13245034/ac-on-light-on.json toggling-light.log https://github.com/ollo69/ha-smartthinq-sensors/files/13245035/toggling-light.log — Reply to this email directly, view it on GitHub https://github.com/ollo69/ha-smartthinq-sensors/issues/475#issuecomment-1791622110, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEI5SI5VS3MMQC4ZTH5CWTYCQKWZAVCNFSM6AAAAAATV4TS4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJRGYZDEMJRGA. You are receiving this because you were mentioned.

ollo69 commented 12 months ago

@All,

please test last release and let me know if switch logic is correct for all.