ollo69 / ha-smartthinq-sensors

HomeAssistant custom integration for SmartThinQ LG devices configurable with Lovelace User Interface.
Apache License 2.0
1.16k stars 159 forks source link

Airco: split swing_mode in horizontal_swing_mode and vertical_swing_mode #597

Open mrombouts opened 1 year ago

mrombouts commented 1 year ago

Currently, LG airco devices have an optiong to set a swing mode using one switch. This switch sets swing mode for horizontal and vertical swing. The status is reported as swing_mode_horizontal and swing_mode_vertical.

See the attributes of the Airco:

hvac_modes:
  - 'off'
  - heat
  - dry
  - cool
  - fan_only
  - heat_cool
min_temp: 16
max_temp: 30
target_temp_step: 1
fan_modes:
  - LOW
  - LOW_MID
  - MID
  - MID_HIGH
  - HIGH
  - NATURE
swing_modes:
  - VerticalOff
  - VerticalTop
  - VerticalMiddleTop1
  - VerticalMiddleTop2
  - VerticalMiddleBottom2
  - VerticalMiddleBottom1
  - VerticalBottom
  - VerticalSwing
  - HorizontalOff
  - HorizontalLeft
  - HorizontalMiddleLeft
  - HorizontalCenter
  - HorizontalMiddleRight
  - HorizontalRight
  - HorizontalLeftHalf
  - HorizontalRightHalf
  - HorizontalSwing
current_temperature: 24.5
temperature: 24
fan_mode: LOW
swing_mode: VerticalTop
swing_mode_horizontal: HorizontalRight
swing_mode_vertical: VerticalTop
friendly_name: Airco Bureau
supported_features: 41

swing_mode is used to set the swing for both horizontal and vertical swing_mode_horizontal is the status of the horizontal swing mode, swing_mode_vertical is the status for the vertical swing mode

It is obviously possible to control this using dashboard programming, the the climate entity continuous to give the wrong information as it only can change swing_mode and can not display the status of the horizontal and vertical swing state: image

Airco is an LG Dual Inverter PC12ST NSJ

Thanks, Michiel

ollo69 commented 1 year ago

The HomeAssistant climate entity do not have separate control for Horizontal and Vertical Swing modes, so this is the only possible solution. The 2 attributes was created to be able at least to understand the current mode for both Hor and Vert modes. There is no way to have different solution based on current HA climate entity feature, and so this cannot be implemented integration side. You can open a request on HomeAssistant site, if they will extend the support I will adjust integration.

mrombouts commented 1 year ago

Hi @ollo69 Thanks for the quick reply - this indeed sounds as a limitation from HA side. It is anyhow great to have those two attributes that reflect the current state!

danielvalido commented 1 month ago

Hi @ollo69

From what I can tell, Home assistant now supports both vertical and horizontal swing modes...

https://github.com/home-assistant/architecture/discussions/553

Can this be implemented now?

Thanks!

ollo69 commented 1 month ago

Are you sure? I still don't see any information about this in developers blog. Anyway I will be happy to implement this as soon as this feature will be available. I re-open this issue in case new information become available.

danielvalido commented 1 month ago

Hi @ollo69

Thanks for the fast reply!

My mistake... It seems that it is still being developed and tested: https://github.com/home-assistant/core/pull/125578

But it will be really nice if you could implement this when it is released in HA.

Thanks!