search

ollo69 / ha-smartthinq-sensors

HomeAssistant custom integration for SmartThinQ LG devices configurable with Lovelace User Interface.
Apache License 2.0
1.13k stars 158 forks source link

Plugin is using deprecated supported features values which will be removed in HA Core 2025.1 #661

Closed hartmood closed 7 months ago

hartmood commented 9 months ago

https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation

ollo69 commented 9 months ago

This is a new deprecation just introduced in 2024.1. To maintain compatibility with previous HA version, I cannot apply this change now. I will wait a couple of new HA version.

hartmood commented 9 months ago

All good, just wanted to let you know. Thanks for making your plugin public.

ollo69 commented 9 months ago

@hartmood,

sorry but I do not understand if you are just informing about deprecation or you receive a specific alert. I think that I already removed this constant some times ago but may be I miss someone.

Thanks,

hartmood commented 8 months ago

I found the error message in my logfile using log viewer and thought it would be helpful for the developer to know.

ollo69 commented 8 months ago

Yes, thanks, but my question is if error message was related to this integration and in case if you can provide details, just because I thought that I already updated all reference but maybe I forgot someone.

Thanks.👍

hartmood commented 8 months ago

I can confirm that I found the error message in my log file a few minutes before posting. And I can confirm I last saw the message a few days ago.

ollo69 commented 8 months ago

Ok, can you provide detail about the message?

hartmood commented 8 months ago

"Plugin is using deprecated supported features values which will be removed in HA Core 2025.1" was the error message. Sorry, I gave very little background information.

ollo69 commented 8 months ago

Ok, could you please provide details about your LG device so I have an idea about what I should search? Thanks.

hartmood commented 8 months ago

:-) - I am sorry: Device Information 2RES1VE61PFWA-SxS (REFRIGERATOR) from LG Firmware: QC_Modem_1.2.80

ollo69 commented 8 months ago

Sorry, but are you running last integration version?

hartmood commented 8 months ago

I have no update pending, so I should be on v0.36.2. Let me know where I can explicitly check the installed version in case.

ollo69 commented 8 months ago

This should be reported in the log during startup, but if you are sure about the version is ok. It is strange because I also have a refrigerator and I don't have any message, anyway I will deeply check.

ollo69 commented 7 months ago

Ok, I found the issue due to some specific device status where supported_feature was returning 0. Will be fixed on next release.

hartmood commented 7 months ago

Wow. Well done. Thank you.