search

ollo69 / ha-smartthinq-sensors

HomeAssistant custom integration for SmartThinQ LG devices configurable with Lovelace User Interface.
Apache License 2.0
1.04k stars 149 forks source link

Fix for HomeKit fan modes (issue #563) #704

Closed diegocjorge closed 4 months ago

diegocjorge commented 4 months ago

All credits to @kparmun for the fix:

https://github.com/ollo69/ha-smartthinq-sensors/issues/563#issuecomment-1612297396

ollo69 commented 4 months ago

It doesn't look really good alter an enum using in some cases lower case and in other upper case. If the problem is that HomeKit just support lower case options, the change should be implemented in the methods fan_speeds, fan_speed and set_fan_speed to convert the values in lower case.

diegocjorge commented 4 months ago

Hey @ollo69, hope it's better now. I'm not much of a coder.

diegocjorge commented 4 months ago

I committed the changes you recommended

ollo69 commented 4 months ago

Not sure this is the right solution. Probably fan modes should be mapped with HA modes. Let me think about this.