Current temperature is not the current temperature on fridge

ollo69 / ha-smartthinq-sensors

HomeAssistant custom integration for SmartThinQ LG devices configurable with Lovelace User Interface.

Apache License 2.0

1.14k stars 159 forks source link

Current temperature is not the current temperature on fridge #801

Open McGiverGim opened 3 weeks ago

McGiverGim commented 3 weeks ago

Describe the bug In the attributes of the fridge entity, there is a "current_temperature: 3". That's not right, the current temperature is unknown, only the "desired" temperature is known for the fridge (I don't know why LG does not publish this data, but it seems it does not for fridges).

It's better to have this value null "current_temperature: null", in this way, the thermostat card of Home Assistant shows the desired temperature but it hides the current temperature (that is unknown).

Expected behavior Don't have current_temperature attribute when this value is unknown.

Environment details:

Environment (HASSIO, Raspbian, etc): HASSIO
Home Assistant version installed: 2024.9.2
Component version installed: 0.39.2
Last know working version: -
LG device type and model with issue: 2REB1GLVB1__2-BF (REFRIGERATOR)
LG devices connected (list):

andorardo commented 1 week ago

I'm having the same problem: https://github.com/ollo69/ha-smartthinq-sensors/issues/800#issuecomment-2394585309

Model number: LRFLS3206S.ASTCNA0

ollo69 commented 1 week ago

It's better to have this value null "current_temperature: null", in this way, the thermostat card of Home Assistant shows the desired temperature but it hides the current temperature (that is unknown).

I think is better to replace climate control with a slider in this case, will avoid confusion. I will manage this change with next release

McGiverGim commented 1 week ago

I think is better to replace climate control with a slider in this case, will avoid confusion. I will manage this change with next release

I don't think so. It's in reality a "climate control" or at least a "thermostat". But the thermostat does not give information about current temperature. That's all.

ollo69 commented 1 week ago

I will try to set current_temperature to none and check the result, not sure this work properly. Looking at the LG app the fridge temperatures are managed by a slider (beautiful, but just a slider)

Screenshot_20241010_101432_LG ThinQ

McGiverGim commented 1 week ago

This is how it looks when I put a "null" value in the developers tools for the current_temperature:

As you see the current temperature disappears.

I don't know if none will work, I think I can't emulate it from the developers tools.

Another thing is that maybe the "Express" modes must be a "mode" of the thermostat, like "auto", but this is another thing and a breaking change.

ollo69 commented 1 week ago

Now I remember that I set the current temperature because in the thermostat interface the target temperature is not shown when the device is set in eco friendly mode and the target temperature feature is disabled. In any case the 2 temperature sensors are still available, so I will set the climate current temperature to none in next release to avoid confusion a let see if someone will complain about this...

McGiverGim commented 4 days ago

Tested latest update in Home Assistant, and it seems to work. It seems the none ends with a null value in the attribute, and it works. Thanks for the change!

Another thing is that maybe the "Express" modes must be a "mode" of the thermostat, like "auto", but this is another thing and a breaking change.

This "feature" remains, but the current switch works so it's not a problem or a need. More a personal like.