search

olmokramer / atom-dark-flat-ui

Dark flat ui theme for Atom
https://atom.io/themes/dark-flat-ui
MIT License
6 stars 7 forks source link

Deprecated selector in `dark-flat-ui/index.less` #5

Open not7cd opened 7 years ago

not7cd commented 7 years ago

In dark-flat-ui/index.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

Jecko-o commented 7 years ago

I was getting the same warning yesterday. As of today i'm getting this.

dark-flat-ui/index.less Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

ghost commented 7 years ago

dark-flat-ui/index.less Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

atom-text-editor::shadow ::-webkit-scrollbar-thumb => atom-text-editor.editor ::-webkit-scrollbar-thumb atom-text-editor::shadow ::-webkit-scrollbar-track, atom-text-editor::shadow ::-webkit-scrollbar-corner => atom-text-editor.editor ::-webkit-scrollbar-track, atom-text-editor.editor ::-webkit-scrollbar-corner atom-text-editor[mini]::shadow .is-focused .selection .region => atom-text-editor[mini].editor .is-focused .selection .region Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

russoue commented 7 years ago

I am having the same issue:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

atom-text-editor::shadow ::-webkit-scrollbar-thumb => atom-text-editor.editor ::-webkit-scrollbar-thumb
atom-text-editor::shadow ::-webkit-scrollbar-track, atom-text-editor::shadow ::-webkit-scrollbar-corner => atom-text-editor.editor ::-webkit-scrollbar-track, atom-text-editor.editor ::-webkit-scrollbar-corner
atom-text-editor[mini]::shadow .is-focused .selection .region => atom-text-editor[mini].editor .is-focused .selection .region
Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

My Atom version is v1.15.0.

artshade commented 7 years ago

Hey all, Was the same issue. The file ~/.atom/packages/dark-flat-ui/styles/index.less includes ~/.atom/packages/dark-flat-ui/styles/editor.less which includes these "bad" lines.

The "Normal" editor.less looks like this:

@import "ui-variables";
@import "ui-mixins";
@import "syntax-variables";

atom-text-editor::shadow {
  ::-webkit-scrollbar-thumb {
    background-color: @syntax-selection-color;
  }

  ::-webkit-scrollbar-track,
  ::-webkit-scrollbar-corner {
    background-color: @syntax-background-color;
  }
}

atom-text-editor[mini] {
  color: @text-color-highlight;
  padding-left: @component-padding / 2;
  background-color: @dark-flat-ui-dark-gray;
  max-height: @component-line-height;

  &.is-focused {
    background-color: @dark-flat-ui-super-duper-dark-gray;
  }

  &::shadow .is-focused .selection .region {
    background-color: @dark-flat-ui-light-gray!important;
  }
}

You should change it to:

@import "ui-variables";
@import "ui-mixins";
@import "syntax-variables";

// atom-text-editor::shadow {
//   ::-webkit-scrollbar-thumb {
//     background-color: @syntax-selection-color;
//   }
//
//   ::-webkit-scrollbar-track,
//   ::-webkit-scrollbar-corner {
//     background-color: @syntax-background-color;
//   }
// }
//
// atom-text-editor[mini] {
//   color: @text-color-highlight;
//   padding-left: @component-padding / 2;
//   background-color: @dark-flat-ui-dark-gray;
//   max-height: @component-line-height;
//
//   &.is-focused {
//     background-color: @dark-flat-ui-super-duper-dark-gray;
//   }
//
//   &::shadow .is-focused .selection .region {
//     background-color: @dark-flat-ui-light-gray!important;
//   }
// }

All in all an issue will disappear.

Best regards hmn, V7

alvis commented 7 years ago

ping @olmokramer

As a lover of dark-flat, I really love to see this thing go away. Either #6 or the change suggested by @vv7v7 should fix the issue.

wooooooooooooooowastaken commented 6 years ago

February 7, 2018 using Atom version 1.23.3

dark-flat-ui\index.less Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

atom-text-editor::shadow ::-webkit-scrollbar-thumb => atom-text-editor.editor ::-webkit-scrollbar-thumb atom-text-editor::shadow ::-webkit-scrollbar-track, atom-text-editor::shadow ::-webkit-scrollbar-corner => atom-text-editor.editor ::-webkit-scrollbar-track, atom-text-editor.editor ::-webkit-scrollbar-corner atom-text-editor[mini]::shadow .is-focused .selection .region => atom-text-editor[mini].editor .is-focused .selection .region Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

alvis commented 6 years ago

@olmokramer: would you mind merging #6 to fix the issue?

alvis commented 6 years ago

ping @olmokramer

ibrokemypie commented 6 years ago

dead theme?

k-hud commented 6 years ago

Same here @olmokramer

olmokramer commented 5 years ago

Hi everyone, I'm sorry for the extremely late reply. As you have probably noticed I've stopped maintaining my Atom plugins a few years ago. I got very frustrated with how Atom was maintained and started ignoring all of my plugins. I'm sorry for that. I won't install Atom to test and mergeer PRs, but I'd be happy to transfer my repositories to anyone that wants to maintain any of my plugins. Again, I'm sorry.

vinimmelo commented 5 years ago

@olmokramer well, i really don't like the way Atom is maintained too; but i can maintain your plugins if you want to. Let me know if you decide to transfer your repositories, i will be happy in maintain them.