search

olmps / memo

Memo is an open-source, programming-oriented spaced repetition software (SRS) written in Flutter.
BSD 3-Clause "New" or "Revised" License
1.82k stars 158 forks source link

Add `FirestoreGateway.getCollection` tests #204

Closed matuella closed 2 years ago

matuella commented 2 years ago

Asked your review again, as I don't think your point is a NIT, so I had to add some personal opinions on this matter

ggirotto commented 2 years ago

Asked your review again, as I don't think your point is a NIT, so I had to add some personal opinions on this matter

I still think this is a NIT because I personally don't use symbols for navigate - they're definitely better, I am just not used to - and I prefer smaller files with less amount of lines. I can't argue that it's better than having everything in a single file - which also have the point of not duplicating stubs as you mentioned -, it's literally my personal preference about it.

Ideally using VSCode symbols + awesome testing descriptions would make the files sizes insignificant, I'm just not used to use it, and maybe I should.

matuella commented 2 years ago

Ideally using VSCode symbols + awesome testing descriptions would make the files sizes insignificant, I'm just not used to use it, and maybe I should.

Ideally, files should be way more compact and contained, but there are use-cases such as these that requires a lot of verbosity, and I advocate for us to not simply split into smaller files just for the sake for splitting it, because we can still deal with it fine, although they'll never be as good as a small files that have between 50 to 200 lines (quite obvious).

matuella commented 2 years ago

All updates made here will be merged in the last PR (#211), in this nested chain of collection execution PRs.