olmps / memo

Memo is an open-source, programming-oriented spaced repetition software (SRS) written in Flutter.
BSD 3-Clause "New" or "Revised" License
1.82k stars 158 forks source link

Adds Memo Creation CTA Empty State #236

Closed ggirotto closed 2 years ago

matuella commented 2 years ago

The goal of this painter was to draw the + CTA (See SS below). Doing it with a painter gives us the flexibility to customize the + and the background circle colors. I sent a message to Bruno to see if we can make the + in the middle transparent to it use the background color. This way I think we may be able to colorize the background circle using Asset.color.

Sure, my point wasn't exactly questioning your implementation, but as to why we have to introduce another brand new button-style "behavior" only to fulfill this screen's empty state. As you've implemented today, it's fine by me, but it's certainly strange to introduce a new "set of themed-buttons" without having them properly documented as a proper application-wide widget that will be used for particular scenarios.