search

olmps / memo

Memo is an open-source, programming-oriented spaced repetition software (SRS) written in Flutter.
BSD 3-Clause "New" or "Revised" License
1.82k stars 158 forks source link

Adds support to update collection details #237

Closed ggirotto closed 2 years ago

ggirotto commented 2 years ago

In this PR I suggest the usage of StateNotifierProviders to control the workflow of a form - in this use-case, the collection details. I honestly see no reasons in this case for using rxdart as we've discussed, even because we could use normal StreamControllers if you disagree about this suggestion.

Open to discussion.

ggirotto commented 2 years ago

Shouldn't all of your useEffect be called only once, thus, passing an empty array of keys to its call?

Makes sense, there's no need to run them on every build

ggirotto commented 2 years ago

@matuella Missed your thoughts about using StateNotifierProvider as the fields validation instead StreamController or even external libs as rxdart. Do you liked the proposal?

ggirotto commented 2 years ago

@matuella Updated to use rxdart and streams as we've discussed