search

olofk / fusesoc

Package manager and build abstraction tool for FPGA/ASIC development
BSD 2-Clause "Simplified" License
1.17k stars 242 forks source link

[RFC] Add early environment variable resolution to fusesoc #600

Closed Jbalkind closed 1 year ago

Jbalkind commented 1 year ago

Adds a --resolve-env-vars-early flag to FuseSoC which allows for environment variables in core files. These are resolved in FuseSoC rather than edalize. I imagine we could add a --resolve-env-vars-late (or make this into a flag with an argument) to enable resolution in edalize for use cases that need that.

olofk commented 1 year ago

This is fine with me. It looks like macosx tests are broken though. Could it be that mkdir is not in /usr/bin on macosx? If so, do we really need to specify an absolute path?

olofk commented 1 year ago

Ah! I understand now that all tests were broken prior to this. Looking at the tox docs, it seems perfectly fine to just allowlist the command without an absolute path, so could you please amend your patch to remove `/usr/bin/' to make tests work again on MacOSX as well?

Jbalkind commented 1 year ago

Ok between that and pulling in your opencores patch, the CI passes. I can juggle those commits around in some other way or you can handle it since I know you don't like merges.

olofk commented 1 year ago

Many thanks! All good from my side. I can do the cherry-picking.

olofk commented 1 year ago

Picked and pushed! All back to green. Thanks