search

olofk / ipyxact

Python-based IP-XACT parser
MIT License
121 stars 47 forks source link

additional fields for 'register' #10

Closed shaydahan closed 5 years ago

shaydahan commented 6 years ago

Hi,

i am using the package for registers description and noticed that you don't include the reset field inside the register type like i have in my ipxact file: image

so i edited the ipyxact_yaml.py file as follows:

  1. added the "reset" field to the "register" CHILDREN image

  2. added a new "reset" field with "value" and "reset" MEMBERS image

and it is working for me (i am using Python 3.6.3 and ipyxact v0.2.3)

Thanks, Shay

olofk commented 6 years ago

Ah, right. I thought that the reset thing was already added. I looked at it a bit now and it turns out that it was implemented for IP-XACT 2014, where the reset tag is a subtag for each field. Looking at your file, you are using an older IP-XACT version where it was still allowed to set reset for a complete register. I need to think a bit how to handle differences between the IP-XACT versions in a good way.

Thanks for reporting. I will try to come up with a solution that works for all IP-XACT versions

olofk commented 5 years ago

ok, so this should be fixed now with 70d2ddcc703cf7112192de49d976b4cd813ccf19 It's still wrong for IP-XACT 2014 but I will work on a more long-term solution