olokelo / jxlpy

Cython bindings and Pillow plugin for JPEG XL
MIT License
45 stars 12 forks source link

Latest libjxl requires JxlEncoderCloseFrames to output valid .jxl #8

Closed alexjc closed 5 months ago

alexjc commented 2 years ago

There's a new API function in the latest libjxl that requires JxlEncoderCloseFrames to be called with the encoder before creating the output. Otherwise, the encoder does not output a well-formed .jxl file, and it fails to decode without --allow_partial_files.

I put this call at the top of get_output() in the Cython file and it seems to work!

olokelo commented 2 years ago

Great! Thanks for reporting. Could you open a pull request so that I can merge it?

alexjc commented 1 year ago

I push my changes here, work in progress: https://github.com/alexjc/jxlpy

alexjc commented 1 year ago

See PR #13.

cmahnke commented 5 months ago

@olokelo: Since #13 has been merged and consequently released, this might get closed.