search

olore / prs-a

PRS-A - Pull Request Sentiment Analyzer
4 stars 2 forks source link

No icon with Waterfox 56.2.1 #11

Open grahamperrin opened 6 years ago

grahamperrin commented 6 years ago

Follow-up to #1

At e.g. https://github.com/MrAlex94/Waterfox/pull/636 I see the icon with Firefox, but not with Waterfox. 

$ pkg info waterfox | grep Version
Version        : 56.2.0.53
$ pkg info firefox | grep Version
Version        : 60.0.2,1
$ date ; uname -v
Sun 17 Jun 2018 19:27:21 BST
FreeBSD 12.0-CURRENT #5 r335024: Wed Jun 13 11:04:24 BST 2018     root@momh167-gjp4-hpelitebook8570p-freebsd:/usr/obj/usr/src/amd64.amd64/sys/GENERIC
olore commented 6 years ago

Hey @grahamperrin thanks for the detailed info. I did a little more research and AMO (addons.mozilla.org) tagged my plugin as firefox57 automatically. I am not sure exactly why, but I'm guessing I am using an API not available in 56, which is what your version of Waterfox is using.

I'll see if I can figure out what it is, but maybe be the time I do, Waterfox will be up to v57.