search

olov / ng-annotate

Add, remove and rebuild AngularJS dependency injection annotations
MIT License
2.03k stars 150 forks source link

Add es6 option #241

Closed ramabouda closed 8 years ago

ramabouda commented 8 years ago

Enables sourceType mode "module" for acorn, to manage import.

It should solve #227, #237 and https://github.com/huston007/ng-annotate-loader/issues/17.

A few changes to the scope tools where needed to support es6 language additions.

ramabouda commented 8 years ago

Any feedback on this?

anlambert commented 8 years ago

It would be nice to have this PR merged. I can confirm that it allows to use ng-annotate with es2015 syntax (see https://github.com/anlambert/webpack-gulp-es6-angular-express for a sample project). Currently, I am forced to use npm-shrinkwrap to fetch ng-annotate from @raphael-boucher repository.

olso commented 8 years ago

@olov Can this be merged?

ramabouda commented 8 years ago

https://github.com/olov/ng-annotate/pull/240 is also needed for complete es6 support.

mjeanroy commented 8 years ago

Hi all, Any news on this? Is there a plan to merge this?

olov commented 8 years ago

https://github.com/olov/ng-annotate/issues/245

olov commented 8 years ago

245