angular.extend() support

[aramk]

angular.extend() usage doesn't seem to be supported by ng-annotate:

export default ngModule => {
  ngModule.directive('fooBar', (fooBar) => {
    return angular.extend({}, fooBar[0], {
      restrict: 'A',
      template: require('./template.html'),
      controllerAs: 'vm',
      controller: function($state, $window) {
        // ...
      }
    });
  })
}

Adding /*@ngInject*/ did it for me:

export default ngModule => {
  ngModule.directive('fooBar', (fooBar) => {
    return angular.extend({}, fooBar[0], {
      restrict: 'A',
      template: require('./template.html'),
      controllerAs: 'vm',
      controller: /*@ngInject*/ function($state, $window) {
        // ...
      }
    });
  })
}

[olov]

https://github.com/olov/ng-annotate/issues/245

[schmod]

Is angular.extend() your problem, or is it the fact that you're doing this in an ES6 export statement?

Either way, I don't think that there's a good path for implicitly detecting annotatable functions inside of something like angular.extend(), _.extend(), or Object.assign() without hard-coding lots of special cases, or potentially picking up tons of false-positives.

Adding /*@ngInject*/ is definitely the way to go here.