olrea / openai-cpp

OpenAI C++ is a community-maintained library for the Open AI API
https://openai.com/api/
MIT License
195 stars 66 forks source link

Can we comply with nlohmann include hierarchy in order to be flexible with external json? #10

Closed sasmaster closed 1 year ago

sasmaster commented 1 year ago

Hi. I am using this library with my own include of nlohmann json. That lib keeps header under 'include/nlohmann". In your library header json dependency looks like this:

#include "json.hpp" // nlohmann/json

Can it be modified to:

#include "nlohmann/json.hpp" // nlohmann/json ?

So that the users would not have to move json.hpp out from nlohmann directory which is default in that library?

Thanks.

coin-au-carre commented 1 year ago

Good point thanks I will definitely manage that :) Meanwhile you can modify it yourself