olrenso / obsidian-home-tab

A browser-like search tab for your local files in Obsidian.
MIT License
248 stars 7 forks source link

[Feature Request] Support for Obsidian Mobile #10

Closed FelipeRearden closed 1 year ago

FelipeRearden commented 1 year ago

Hello @olrenso !!!!!

First of all, fantastic idea !!!!!! This is exactly what we need when opening a new tab. The amount of possibilites for this plugin is endless

My first FR is easy to explain: would you mind adding support for Obsidian Mobile ?

→ I use Obsidian Mobile on iPad with a mouse and keyboard and I would like to have the same workflow on mobile that I have on Desktop 🙏

🆘 I tried to enable the plugin on Mobile and checking the Console I found this error:

[error] Plugin failure: home-tab SyntaxError: Invalid regular expression: invalid group specifier name 

I was able to find the error using the plugin Mobile Logging


Thanks for reading this!

Have a great day!!!

olrenso commented 1 year ago

Thank you for the FR. Currently, the mobile version is disabled since I still need to optimize the Home tab view for smaller screens.

🆘 I tried to enable the plugin on Mobile and checking the Console I found this error:

[error] Plugin failure: home-tab SyntaxError: Invalid regular expression: invalid group specifier name

It seems related to the regex expression I use to validate links in the settings. I'll take a look into that.

FelipeRearden commented 1 year ago

Thank you for the FR. Currently, the mobile version is disabled since I still need to optimize the Home tab view for smaller screens.

Thank for the feedback and for the reply @olrenso !!!!!

It seems related to the regex expression I use to validate links in the settings. I'll take a look into that.

Yeah, its the classic issue for plugins on Mobile :)

I hope its an easy one 🙏

Just to let you know that you can emulate Mobile on Desktop using this command on Console

image


Have a great day ☀️

olrenso commented 1 year ago

As of 1.1.0, the plugin should work also on mobile, though I didn't test it extensively.

FelipeRearden commented 1 year ago

As of 1.1.0, the plugin should work also on mobile, though I didn't test it extensively.

Thank you very much @olrenso !!!! I am gonna start using on Mobile and I let you know if something is strange :)

Thank you very much for this. I wish you a fantastic day ☀️

FelipeRearden commented 1 year ago

Hello @olrenso !!!!

🆘 I found an issue on Mobile :(

🦶 Steps to Reproduce...

1️⃣ Type something in the Search field 2️⃣ Choose a File to open and hit ENTER 3️⃣ In the new active note, you will see that ↑↓ DON'T work. You cant change lines 4️⃣ If you hit ENTER it will replace the active note with a NEW NOTE that was one of the notes was visible in the Home Tab search field

🐚 In a nutshell: after opening a NOTE, looks like that the focus is still in the Home Tab instead of the openned note. This way, some keyboard actions will be executed based on the Home Tab instead of the OPENNED Note.

❌ Unfortunately, there is no errors on Console :(

📹 I hope this video helps. I limit the search for 3 files to make easy for us to see the issue

video

ℹ️ As you can see, hitting ENTER cycle between the three notes that was suggested in the search field


I hope my test could help to solve this issue 🙏

olrenso commented 1 year ago

Thank you for the detailed bug report. I’ll take a look as soon as possible.

olrenso commented 1 year ago

I added a potential fix with 1.1.1. Let me know if it works.

FelipeRearden commented 1 year ago

I added a potential fix with 1.1.1. Let me know if it works.

Thank you very much for the quick fix @olrenso !!!!

It's working perfect now. I am gonna stress a little bit more on my main vault and I let you now if I found something strange.

I wish you a fantastic day!!!!

olrenso commented 1 year ago

Perfect! I'm closing this FR. If you find any new bugs feel free to open a new issue.

FelipeRearden commented 1 year ago

Perfect! I'm closing this FR. If you find any new bugs feel free to open a new issue.

100% agree @olrenso !!!!

Thanks for all of your attention with this FR :)