search

olsak / OpTeX

OpTeX - LuaTeX format with extended Plain TeX macros
http://petr.olsak.net/optex/
35 stars 13 forks source link

Use proper \foreach while loading Tikz packages #111

Closed cao- closed 1 year ago

cao- commented 1 year ago

This could be a solution to #108 . But I'm not sure this is the best way to deal with it.

cao- commented 1 year ago

This PR is not relevant anymore and should be closed, the issue was already solved with your last commit. Anyhow, I take it as an opportunity to make you notice a potentially unwanted behaviour I spotted in the tikz.opm code. I see that at the end we do \_let\foreach=\_optexforeach, so we enforce \foreach to have the default meaning defined in OpTeX. Shouldn't we restore it to the meaning it had before loading this file? Maybe the user already redefined it before doing \load[tikz] and doesn't want the default meaning to be enforced.

olsak commented 1 year ago

Solved by commit https://github.com/olsak/OpTeX/commit/528991dee8cb52de6b7d477d2ce91a5d346c858c