search

olsh / Feedly-Notifier-Firefox

[DEPRECATED - https://github.com/olsh/Feedly-Notifier] Firefox extension for reading news from rss aggregator Feedly
http://olsh.github.io/Feedly-Notifier/
Mozilla Public License 2.0
22 stars 7 forks source link

Middle-clicking a title opens a second tab with `javascript:void(0)` #127

Open ThiefMaster opened 8 years ago

christantoan commented 8 years ago

Same here

gajdipajti commented 8 years ago

The issue exists also with Firefox version 44.0b4. Both Windows and Linux.

olsh commented 8 years ago

Can't reproduce. Have you tried to reproduce the bug in a clean FF profile?

ThiefMaster commented 8 years ago

Why not just remove the href="javascript:void(0)" from the links and preventDefault the event in the JS event handler that also handles opening the new tab?

olsh commented 8 years ago

@ThiefMaster yes, it's the most obvious solution. But preventDefault doesn't work in the popup.

malibuzios commented 8 years ago

@olsh

I'm also experiencing this constantly (I have a habit of using the middle click for links, it is very hard to change it). Here are some animated screen captures:

middle click article

This also happens when clicking the "Feedly website", though here only the javascript:void(0) window opens. middle click website link

I'm using 2.10.12 on Firefox 45.0.1 x64, Windows 10 x64. Default theme. All extensions disabled apart from this one.

In any case, I wanted to thank you for making this useful extension, I've become quite dependent on it for several years now..

olsh commented 8 years ago

Blocked by this.

Panel limitations ... Mouse button shortcuts, such as using the middle button to open a link in a new page, don't work.

malibuzios commented 8 years ago

@olsh

I searched but so far I couldn't find a bugzilla issue that tracks this. Somebody did file an issue, though, for cmd+click a link in a panel should open the link in a new tab and it is marked as "fixed", though it seems to have the same behavior as middle-click in this extension's panel.