search

olsh / Feedly-Notifier

Google Chrome, Firefox, Opera and Microsoft Edge extension for reading news from RSS aggregator Feedly
http://olsh.github.io/Feedly-Notifier/
Mozilla Public License 2.0
273 stars 38 forks source link

Add support for Notification Sound extension #110

Closed freaktechnik closed 6 years ago

freaktechnik commented 7 years ago

Notification Sound (currently Firefox only) plays a user-defined sound whenever a notification is shown. Currently it requires extensions to tell it about notifications. This simple patch adds that notification, and should only be added to the Firefox version, from how I understand the build system.

olsh commented 7 years ago

Hi @freaktechnik! Thanks for the PR. 👍

What is Notification Sound, it's an API?

btw, the extension already has sound notifications https://github.com/olsh/Feedly-Notifier/blob/master/src/scripts/core.js#L371-L375

freaktechnik commented 7 years ago

What is Notification Sound, it's an API?

It is an extension whose purpose it is to play a sound when notifications are shown, though in theory other extensions can make it play a sound whenever they want. The idea there is that users on an OS without built in sounds in the notification system have a single sound they can define for all notifications.

btw, the extension already has sound notifications https://github.com/olsh/Feedly-Notifier/blob/master/src/scripts/core.js#L371-L375

Ah, sorry, didn't see that.