olsh / Feedly-Notifier

Google Chrome, Firefox, Opera and Microsoft Edge extension for reading news from RSS aggregator Feedly
http://olsh.github.io/Feedly-Notifier/
Mozilla Public License 2.0
273 stars 38 forks source link

HD icons, and minor UI polishing #116

Closed Jackymancs4 closed 6 years ago

Jackymancs4 commented 6 years ago

Hello, trying to solve #101

Before After
real - initial - 2 final-2

I used https://getbootstrap.com/docs/3.3/components/#glyphicons-glyphs inside a very lightweight custom build (made with https://getbootstrap.com/docs/3.3/customize/). I fixed the popup-actions subtitles that now stay in place and display the little green arrow-up I also forced icon48.png instead of icon.png.

The PR is still not finished. Things that are still missing:

  1. the open-unsaved-all-news element (which I have not fully understood)
  2. save-feed that seems to use a custom icon (save.png)
  3. style.css require some cleaning from unused elements
  4. if merged, glyphicons-halflings.png should be deleted

The whole PR has been tested on firefox 58 (Screeshot) and Chrome 64.

olsh commented 6 years ago

Hello @Jackymancs4,

Thank for the PR, great job 👍

the open-unsaved-all-news element (which I have not fully understood)

This just opens all saved news and unsaves them. You can see the button if you click on the Saved tab.

save-feed that seems to use a custom icon (save.png)

We would replace the icon with glyphicon glyphicon-bookmark

style.css require some cleaning from unused elements if merged, glyphicons-halflings.png should be deleted

I'll do that, if I have some time,

Jackymancs4 commented 6 years ago

This just opens all saved news and unsaves them. You can see the button if you click on the Saved tab.

Cool, a feature I never knew existed! And here some new screenshots with the newest update:

schermata 2018-02-09 alle 16 06 11 2 schermata 2018-02-09 alle 16 06 14 2 schermata 2018-02-09 alle 16 09 12 2

Problems 1, 2, and 4 should be fixed 👍

olsh commented 6 years ago

@Jackymancs4 thank you. All your work with minor changes was merged to master in #117 👍