olsh / Feedly-Notifier

Google Chrome, Firefox, Opera and Microsoft Edge extension for reading news from RSS aggregator Feedly
http://olsh.github.io/Feedly-Notifier/
Mozilla Public License 2.0
273 stars 38 forks source link

Popup window is broken #122

Closed morawcik closed 6 years ago

morawcik commented 6 years ago

Hi Starts from couple days ago most time when I'm trying open popup window it opens normal but then very fast switch to so small like 50x50px. There are a times when it opens normal and stay normal but it's like 20% from every opening.

zrzut ekranu 2018-04-26 o 23 50 18 zrzut ekranu 2018-04-26 o 23 52 31

olsh commented 6 years ago

Hi, could you please specify your browser?

morawcik commented 6 years ago

Google Chrome was 65.* (not know details) and now 66.0.3359.139 (64 bits) - broken on both

navarr commented 6 years ago

I am also having this issue on Chrome 66.0.3359.139 (Mac OS X High Sierra).

Occasionally it works fine, but most of the time it shrinks back to the small window.

olsh commented 6 years ago

I can't reproduce this issue on Windows 10. @morawcik are you using Mac too?

morawcik commented 6 years ago

Yes, Mac OS X Sierra and High Sierra

olsh commented 6 years ago

Probably related to https://github.com/olsh/Feedly-Notifier/blob/master/src/scripts/popup.js#L190-L193

I'll try to find a Mac to test.

olsh commented 6 years ago

I can't reproduce this issue on a test Mac. So it would be nice if anybody helps me with this issue.

I'm 99% sure that this issue is caused this bug: https://bugs.chromium.org/p/chromium/issues/detail?id=307912 I tried workaround this bug with this code but it seems like it's not a perfect solution.

morawcik commented 6 years ago

What help?

I think that it can be this bug but I had this problem only with Feedly Notifier.

madhur commented 6 years ago

I am having same issue.

screen shot 2018-05-07 at 9 38 05 am

Running MAC OSX Sierra 10.12.6

Chrome Version 66.0.3359.139 (Official Build) (64-bit)

olsh commented 6 years ago

Guys, if you can, please build the extension from the sources and play with the code (remove it, increase interval etc.): https://github.com/olsh/Feedly-Notifier/blob/master/src/scripts/popup.js#L190-L193

Here are the build steps: https://github.com/olsh/Feedly-Notifier#build

morawcik commented 6 years ago

I removed this if for mac and popup with login button works fine but trying login I'm getting "invalid redirect_uri" error

olsh commented 6 years ago

Are you using the lastes keys for the sandbox? https://groups.google.com/forum/#!topic/feedly-cloud/lvGXcO5uzas

morawcik commented 6 years ago

Yes. I need do/change sth more than this kay for command line?

akaSybe commented 6 years ago

I'll take a look in the evening

morawcik commented 6 years ago

But @olsh before removed this if statement even popup with login button was broken so maybe this is solution for all this problem?

olsh commented 6 years ago

@morawcik just pushed a fix for the sandbox build, please rebuild the extension.

But @olsh before removed this if statement even popup with login button was broken so maybe this is solution for all this problem?

Probably, but we need to test this. Here is the long thread about the issue: https://github.com/olsh/Feedly-Notifier/issues/59

morawcik commented 6 years ago

Thanks. So removing if statement helps but it's not a solution - popup still resizing to small version but much less often.

morawcik commented 6 years ago

I changed timeout to 500 and no issue for couple of min opening popup. I'll write if I'll get it again.

olsh commented 6 years ago

@morawcik how the testing is going, any issues?

Could you please send a PR if everything is ok?

akaSybe commented 6 years ago

I increased timeout for Mac. New version will be available in store soon.

morawcik commented 6 years ago

Nice, thanks @akaSybe

Sorry @olsh I just back to home. It works great - no single problem :)

olsh commented 6 years ago

Cool, I'm closing this issue out then. Feel free to reopen it if you still have the bug.