Can't load favicons of feed sites

olsh / Feedly-Notifier

Google Chrome, Firefox, Opera and Microsoft Edge extension for reading news from RSS aggregator Feedly

http://olsh.github.io/Feedly-Notifier/

Mozilla Public License 2.0

267 stars 38 forks source link

Can't load favicons of feed sites #163

Closed wrooot closed 4 years ago

wrooot commented 4 years ago

Describe the bug Started a day ago. Feedly Notifier can't load favicons of sites in the list. Not sure if this is some change on Feedly size. I haven't updated or changed anything in these two days i think.

To Reproduce Steps to reproduce the behavior:

Open the list of new articles by pressing Feedly Notifier icon.
Wait for ~10 seconds while it tries to load the icons.
It shows a placeholder broken image icon.

Expected behavior It should be loading icons as it did a few days ago.

Screenshots

Desktop (please complete the following information):

OS: Windows 7 Pro x64
Browser: Mozilla Firefox x64
Version 75.0

olsh commented 4 years ago

Thanks for the reporting, my icon server went down.

Fixed now.

wrooot commented 4 years ago

I didn't know there is a server for the icons. Was it necessary to implement this way?

olsh commented 4 years ago

Well, there are two reasons why I set up a custom server for icons:

Feedly uses google service for getting icon, and it doesn't work on some domains, here is an example Google: https://www.google.com/s2/favicons?domain=github.com&alt=feed Custom: https://i.olsh.me/icon?url=https://github.com&size=16..64..300&fallback_icon_url=https://www.google.com/s2/favicons?domain=https://github.com&alt=feed
The second reason, the google service generates icons in low resolution 16x16, and these favicons look not pretty well on desktop notifications, the custom server tries to fetch icon with 64x64 resolution.

If you know alternatives, let me know.