olsh / Feedly-Notifier

Google Chrome, Firefox, Opera and Microsoft Edge extension for reading news from RSS aggregator Feedly
http://olsh.github.io/Feedly-Notifier/
Mozilla Public License 2.0
273 stars 38 forks source link

Adding github action for automated submission and dependabot upkeep #201

Closed louisgv closed 2 years ago

louisgv commented 2 years ago

Hi @olsh,

Love the extension :D I was looking for ways to contribute, and thought adding a bit more ci might help. I created 2 workflows in this PR:

The only thing you would need to create are 3 github repository secrets: SUBMIT_KEYS, FEEDLY_CLIENT_ID and FEEDLY_CLIENT_SECRET.

The SUBMIT_KEYS secret is a json, with the schema defined here.

Here's a sample key:

{
    "$schema": "https://raw.githubusercontent.com/plasmo-corp/bpp/main/keys.schema.json",
    "chrome": {
        "zip": "build/feedly-notifier-chrome.zip",
        "clientId": "123",
        "refreshToken": "789",
        "extId": "abcd"
    },
    "firefox": {
        "zip": "build/feedly-notifier-firefox.zip",
        "apiKey": "abcd",
        "apiSecret": "abcd"
    },
    "opera": {
        "zip": "build/feedly-notifier-opera.zip",
        "packageId": 0,
        "csrftoken": "abcd",
        "sessionid": "abcd"
    }
}

You can find instructions on how to get the keys in the schema, or in this doc. If you use vscode, the schema should provide hint/intelisense when hovering over the json properties. If you need any help in setting up the keys, feel free to @ me! Otherwise if this doesn't seem necessary, feel free to close the PR :)


Side notes: bpp is an open source action, together with its dependencies. You can audit the source as well as providing any issue/feedback here:

olsh commented 2 years ago

Hi @louisgv

Thank you for the PR. This contribution is really useful. Could you please use yarn instead of npm in these workflows?

louisgv commented 2 years ago

Could you please use yarn instead of npm in these workflows?

Done in f88f03a! I did a bit of investigation on the github action environment, it seems the yarn version is frozen at Yarn 1.22.17: https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-Readme.md

Thus, there's no yarn dlx from yarn 2. npx is still needed to run grunt.

olsh commented 2 years ago

Thank you! 💯