search

olsh / Feedly-Notifier

Google Chrome, Firefox, Opera and Microsoft Edge extension for reading news from RSS aggregator Feedly
http://olsh.github.io/Feedly-Notifier/
Mozilla Public License 2.0
273 stars 38 forks source link

Icons are not loaded #206

Closed duoduobingbing closed 2 years ago

duoduobingbing commented 2 years ago

Describe the bug Small thumbnail icons are not loaded

To Reproduce

  1. open add-on window
  2. see posts without icons

Expected behavior icons should be displayed

Suspected Issue Using the option Load this image in a different tab reveals that the icon was supposed to be loaded from https://i.olsh.me/icon?url=https://www.youtube.com&size=16..64..300&fallback_icon_url=https://www.google.com/s2/favicons?domain=https://www.youtube.com%26sz=64%26alt=feed. The domain i.olsh.me seems to have expired thus causing the load of all small icons to fail

olsh commented 2 years ago

Hi @duoduobingbing

olsh.me domain cannot be renewed because I'm Russian. Basically, I cannot renew it because of sanctions. I'm transferring the domain to another registrar that is available for Russians.

RejZoRSheep commented 2 years ago

Hi @duoduobingbing

olsh.me domain cannot be renewed because I'm Russian. Basically, I cannot renew it because of sanctions. I'm transferring the domain to another registrar that is available for Russians.

I honestly wouldn't mind if you just add option to disable those icons entirely in the settings. So we can uncheck the option and just disable them entirely. Easier to live without the icons than knowing they are suppose to be there but aren't showing and you only see a placeholder spot...

gwolf2u commented 2 years ago

why not simply use the fallback url? https://github.com/olsh/Feedly-Notifier/blob/master/src/scripts/core.js#L734

RejZoRSheep commented 2 years ago

why not simply use the fallback url? https://github.com/olsh/Feedly-Notifier/blob/master/src/scripts/core.js#L734

Better question, why does it even have to parse icons from a 3rd party domain to begin with? Why not just use the source of the feed?

olsh commented 2 years ago

Hi guys,

why not simply use the fallback url?

Here are reasons why I set up a custom icon server https://github.com/olsh/Feedly-Notifier/issues/163#issuecomment-614453428

Better question, why does it even have to parse icons from a 3rd party domain to begin with? Why not just use the source of the feed?

What do you mean by the source of the feed?

vahancho commented 2 years ago

Hi Oleg,

First of all, thank you for the great extension. I use to use it several years and was quite happy. The resent changes are annoying of course - it's hard to see which item belongs to which feed, while icons were a good visual indication. IMO having a dummy icon or an icon with lower resolution is better than nothing. This ugly placeholder is really annoying. What about this service: https://github.com/feedbin/feedbin-api/blob/master/content/icons.md ? Not sure how it works - just randomly searched.

duoduobingbing commented 2 years ago

@olsh Thanks for replying so quickly.

One option would be to temporarily switch the icon loading to Google entirely and then switch back to a custom domain when there is one available. I guess most users would prefer the 16x16 icons over no icons at all for the time being.

Another option would be to switch to a .ru-Domain or use a Domain Registrar that allows anonymous (or for that matter non Visa/Mastercard dependent) payment with e.g. Bitcoin. Namecheap seems supports Bitcoin payments.

olsh commented 2 years ago

Hi guys,

Thank you for your help and kind words. I've migrated the domain to a new registrar. The icons should start working soon.

zoispag commented 2 years ago

Hi guys,

Thank you for your help and kind words. I've migrated the domain to a new registrar. The icons should start working soon.

I can confirm they are now working! Thanks