search

olsh / Feedly-Notifier

Google Chrome, Firefox, Opera and Microsoft Edge extension for reading news from RSS aggregator Feedly
http://olsh.github.io/Feedly-Notifier/
Mozilla Public License 2.0
267 stars 38 forks source link

Notification counter behavior is inconsistent/broken #283

Closed thereddestdog closed 3 weeks ago

thereddestdog commented 1 month ago

Describe the bug Unread counter does not show when there are over 1,000 unread items, and is not showing correct counter (or at all) when there are a lot of unread items

Expected behavior The counter should display 1k+ or the actual unread count if under 1,000

image

image

image

image

Running Firefox v129.0.2 64-bit on Windows 11 22H2

thereddestdog commented 1 month ago

As a test, I disabled every other Add-on and that did not fix the issue. I accidentally disabled Feedly Notifier, and when I re-enabled it and logged back in, it did display the correct count of 829 initially. But then clicking the Add-on icon to reload, it did not show the count

image

image

olsh commented 1 month ago

Well, I think the culprit is the option from your screencap image

thereddestdog commented 1 month ago

How should that option behave then? I'm expecting it to read in the current unread count when I click

I did turn that option off, and I can now see the correct count of unread items

olsh commented 1 month ago

When the option is enabled, it resets the counter to 0 every time when you click the extension button.

olsh commented 1 month ago

Regarding the original question, I think you were logged in under a different account. You can check the current user on the bottom of the option page.

thereddestdog commented 1 month ago

OK, so after that, when does it update with the correct count? Because I was seeing a 1, 2, or 3 displayed when I have 800+ items unread.. Oh maybe that low number is the amount of new items that came in since clicking reset... I think I follow how it is supposed to work now.

And I only have one account, FYI

olsh commented 1 month ago

OK, so after that, when does it update with the correct count?

It only counts new articles that were published after the counter was reset.

thereddestdog commented 1 month ago

OK makes sense, thank you!

thereddestdog commented 4 weeks ago

Hi @olsh now that I understand how that counter should work, I noticed that it does not accommodate counts of 1000+

Can you make this show 1k+ instead of three digits? Thanks!

image

olsh commented 4 weeks ago

You might want to consider opening a new issue for this. Unfortunately, I don't have time to address it right now, but a pull request would be appreciated.

Here's the code responsible for updating the badge. https://github.com/olsh/Feedly-Notifier/blob/8b5329cd4438ee7b331a4f1380bc03fe42b0ec1f/src/scripts/core.js#L447-L462

thereddestdog commented 3 weeks ago

Thanks again for #0da06b8