olsh / Feedly-Notifier

Google Chrome, Firefox, Opera and Microsoft Edge extension for reading news from RSS aggregator Feedly
http://olsh.github.io/Feedly-Notifier/
Mozilla Public License 2.0
273 stars 38 forks source link

Timing issues causes popup to shrink #59

Closed tveimo closed 7 years ago

tveimo commented 8 years ago

When using "Open feeds in background tab", the popup opens, but immediately shrinks to a very small size, prob about 100x100 pixels. If I click the button several times, I am sometimes successfull in opening the popup to its proper size.

olsh commented 7 years ago

You don't need to edit anything manually. Run the following command: grunt sandbox --clientId=sandbox --clientSecret=OE12J47X2W5PEF7CKPGZ --browser chrome

Load the extension from the build directory and login. After that go to https://sandbox.feedly.com/ and add some feeds.

tveimo commented 7 years ago

Ok, I'm still only getting a login button in the extension though, so am unable to test.

tveimo commented 7 years ago

Sorry for the noise. I didn't realise the client secret expires after a while and that the one in the REAME.md file is too old, am now using OE12J47X2W5PEF7CKPGZ, which works.

Changing the timeout of the executeAsync() method in popup.js from 0 to 150 seems to fix the shrinking popup issues on my macbook pro;

function executeAsync(func) { setTimeout(function () { func(); }, 150); }

Can we please have a public release with that change, possibly optioned for mac clients only?

olsh commented 7 years ago

@tveimo Thanks for the info, could you please get the latest version and test it again? I've added the timeout for mac here https://github.com/olsh/Feedly-Notifier/blob/master/src/scripts/popup.js#L194-L201

olsh commented 7 years ago

I've just pushed a new version with the fix live. Please try it out.

DavidBabel commented 7 years ago

seems to work for me

tveimo commented 7 years ago

Works for me too. Suggest closing as resolved for now.

olsh commented 7 years ago

Thanks guys! Feel free to reopen it.