search

olsh / Feedly-Notifier

Google Chrome, Firefox, Opera and Microsoft Edge extension for reading news from RSS aggregator Feedly
http://olsh.github.io/Feedly-Notifier/
Mozilla Public License 2.0
273 stars 38 forks source link

Use blog icon in notification #78

Closed asarium closed 7 years ago

asarium commented 7 years ago

b8b688098bb4ccd9f2bf737a9df38eb849025d35 changed the notification icon URL to always use the default Feedly icon. These changes fix that behavior by using the favicon URL which was used in previous versions.

This required a change to the extensions permissions since the extension now needs to access arbitrary URLs for downloading the images.

olsh commented 7 years ago

Thanks for the PR. 👍

wsong commented 7 years ago

This PR requires created a big, scary change in permissions just for favicon support. I understand the rationale behind this change, but perhaps it's not worth it? I know that, at least for my part, I was quite put off when I saw that this extension now required permissions for all URLs.

mkatsevVR commented 7 years ago

it does seem excessive...

tarmo-randma commented 7 years ago

Wave of uninstalls coming with this permissions change

anotherjames commented 7 years ago

Yeah, I'm uninstalling now. I would very gladly return if the need for this permission could be removed please.

WORMSS commented 7 years ago

Can we not have a cutdown version then? I don't even know where you are needing the favicon?? All I use the app for is to show [1] or [20] or what ever amount of unread feeds.. Soon as I press the icon, it opens up the Feedly webpage, no popup at all. I have been using this extension like that (basically since Google Reader closed) that I forgot it even had a popup.

The fav-icon support could be added as an optional permission. See #81 so if someone ticks a checkbox to view fav-icons, they can see them.

anotherjames commented 7 years ago

I have always used this extension's popup. I would gladly accept not seeing the blog's own icon in order to avoid granting permission to access arbitrary URLs. The 'optional permission' suggestion sounds perfect.

I'm using Notifier for Feedly for now, it just shows a count, and clicking the extension icon jumps to the Feedly webpage. So it would probably work for you @WORMSS . No popup though :-(

(Sorry to post a link to an alternative, but this change is driving users away as it is.)

WORMSS commented 7 years ago

That does sound perfect for me @anotherjames . Thank you.

I will wait a little while to see what @olsh does with this. I have used this extension a long time and not caused me grief until now. Would like to stay if possible.

olsh commented 7 years ago

Whoa, didn't think that free and open source extension without any ads may be the cause of such resentment. :) If we'd wanted to make money on this extension, we'd sold it long ago.

But I agree with @WORMSS that we need to make the permissions optional.

anotherjames commented 7 years ago

Sorry @olsh I don't mean to sound resentful! The app has long been brilliant - thank you! Changes to any software, free or not, is sometimes not for the best, that's all.

Thanks for responding though and agreeing on a way forward.

olsh commented 7 years ago

The new version was published, let me know if everything works as expected.

anotherjames commented 7 years ago

Yes, thank you very much!